Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deprecate old I/O functions #481

Merged
merged 1 commit into from
Jan 22, 2025
Merged

chore: Deprecate old I/O functions #481

merged 1 commit into from
Jan 22, 2025

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Jan 22, 2025

No description provided.

@krlmlr krlmlr enabled auto-merge (squash) January 22, 2025 15:54
@krlmlr krlmlr merged commit 8d9ad91 into main Jan 22, 2025
21 checks passed
@krlmlr krlmlr deleted the f-deprecate-io branch January 22, 2025 16:20
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 463de58 is merged into main:

  • ✔️001_tpch_01: 26.1ms -> 25.2ms [-7.52%, +0.46%]
  • ✔️001_tpch_02: 73.3ms -> 74.4ms [-1.29%, +4.18%]
  • ✔️001_tpch_03: 43.5ms -> 43.9ms [-1.18%, +3.02%]
  • ✔️001_tpch_04: 24.6ms -> 24.5ms [-1.82%, +1.52%]
  • ✔️001_tpch_05: 65ms -> 63.9ms [-3.87%, +0.64%]
  • ✔️001_tpch_06: 15.9ms -> 16.1ms [-1.7%, +3.25%]
  • ✔️001_tpch_07: 78.7ms -> 78.9ms [-1.41%, +2.1%]
  • ✔️001_tpch_08: 103ms -> 103ms [-1.76%, +2.71%]
  • ✔️001_tpch_09: 78.2ms -> 78.9ms [-1.53%, +3.49%]
  • ✔️001_tpch_10: 52.1ms -> 51.6ms [-2.49%, +0.76%]
  • ✔️001_tpch_11: 33.8ms -> 34.4ms [-0.14%, +3.56%]
  • ✔️001_tpch_12: 28.2ms -> 28.2ms [-1.84%, +1.72%]
  • ✔️001_tpch_13: 26.5ms -> 26.7ms [-1.21%, +2.75%]
  • ✔️001_tpch_14: 20.7ms -> 20.8ms [-3.14%, +4.19%]
  • ✔️001_tpch_15: 32.4ms -> 32.9ms [-1.11%, +4.15%]
  • ✔️001_tpch_16: 41.5ms -> 41.5ms [-1.75%, +1.72%]
  • ✔️001_tpch_17: 27.1ms -> 27ms [-2.52%, +1.59%]
  • ✔️001_tpch_18: 22.7ms -> 23.2ms [-0.81%, +5.32%]
  • ✔️001_tpch_19: 68ms -> 68.3ms [-0.46%, +1.4%]
  • ✔️001_tpch_20: 53.5ms -> 53.7ms [-1.44%, +2.13%]
  • ❗🐌001_tpch_21: 81ms -> 84.1ms [+1.63%, +6%]
  • ✔️001_tpch_22: 70.8ms -> 70.3ms [-3.83%, +2.33%]
  • ✔️010_tpch_01: 81.2ms -> 84.2ms [-1.5%, +8.95%]
  • ✔️010_tpch_02: 73.8ms -> 73.4ms [-2.29%, +1.15%]
  • ✔️010_tpch_03: 61.1ms -> 60.5ms [-2.94%, +0.96%]
  • ✔️010_tpch_04: 45.2ms -> 44ms [-7.23%, +1.69%]
  • ✔️010_tpch_05: 95.8ms -> 94.8ms [-2.75%, +0.68%]
  • ✔️010_tpch_06: 35.4ms -> 34.3ms [-9.9%, +3.2%]
  • ✔️010_tpch_07: 114ms -> 115ms [-3.19%, +5.21%]
  • ✔️010_tpch_08: 135ms -> 136ms [-2.1%, +3.41%]
  • ✔️010_tpch_09: 124ms -> 124ms [-3.54%, +2.88%]
  • ✔️010_tpch_10: 79.3ms -> 77.7ms [-5.69%, +1.72%]
  • ✔️010_tpch_11: 41.5ms -> 41.5ms [-4.57%, +4.45%]
  • ✔️010_tpch_12: 57.9ms -> 57.5ms [-1.93%, +0.51%]
  • ✔️010_tpch_13: 53.2ms -> 53.1ms [-1.65%, +1.42%]
  • ❗🐌010_tpch_14: 37.9ms -> 38.4ms [+0.18%, +2.58%]
  • ✔️010_tpch_15: 54.9ms -> 56ms [-5.33%, +9.58%]
  • ✔️010_tpch_16: 46.2ms -> 46.5ms [-1.76%, +3.04%]
  • ✔️010_tpch_17: 57.1ms -> 57.1ms [-5.13%, +5.06%]
  • ✔️010_tpch_18: 59.5ms -> 57.7ms [-11.53%, +5.35%]
  • ✔️010_tpch_19: 120ms -> 120ms [-2%, +1.98%]
  • ✔️010_tpch_20: 68.1ms -> 67.5ms [-3.9%, +2.17%]
  • ✔️010_tpch_21: 244ms -> 246ms [-1.58%, +2.97%]
  • ✔️010_tpch_22: 80.9ms -> 80.3ms [-3.62%, +2.08%]
  • ✔️100_tpch_01: 329ms -> 336ms [-5.2%, +9.12%]
  • ✔️100_tpch_02: 126ms -> 123ms [-4.77%, +0.34%]
  • ✔️100_tpch_03: 183ms -> 183ms [-2.83%, +3.58%]
  • ✔️100_tpch_04: 154ms -> 157ms [-2.41%, +5.62%]
  • ✔️100_tpch_05: 255ms -> 263ms [-7.48%, +13.59%]
  • ✔️100_tpch_06: 108ms -> 104ms [-20.45%, +11.43%]
  • ✔️100_tpch_07: 241ms -> 246ms [-7.85%, +12.24%]
  • ✔️100_tpch_08: 274ms -> 267ms [-13.86%, +8.74%]
  • ✔️100_tpch_09: 341ms -> 335ms [-17.66%, +14.59%]
  • ✔️100_tpch_10: 217ms -> 211ms [-10.55%, +5.51%]
  • ✔️100_tpch_11: 86.5ms -> 83.1ms [-12.28%, +4.42%]
  • ✔️100_tpch_12: 199ms -> 189ms [-18.01%, +7.16%]
  • ✔️100_tpch_13: 326ms -> 320ms [-4.8%, +0.75%]
  • ✔️100_tpch_14: 133ms -> 117ms [-25.82%, +1.21%]
  • ✔️100_tpch_15: 223ms -> 220ms [-11.15%, +9.01%]
  • ✔️100_tpch_16: 136ms -> 125ms [-28.28%, +13.24%]
  • ✔️100_tpch_17: 184ms -> 184ms [-4.45%, +4.21%]
  • ✔️100_tpch_18: 193ms -> 204ms [-5.91%, +17.52%]
  • ✔️100_tpch_19: 292ms -> 299ms [-12.44%, +16.89%]
  • ✔️100_tpch_20: 186ms -> 184ms [-7.79%, +5.35%]
  • ✔️100_tpch_21: 1.36s -> 1.38s [-9.28%, +12.57%]
  • ✔️100_tpch_22: 174ms -> 174ms [-3.91%, +4.4%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant