Skip to content

Commit

Permalink
Merge pull request #62 from tidepool-org/gordyd/update-upload-url
Browse files Browse the repository at this point in the history
Remove user session id from uploadUrl - potential security risk
  • Loading branch information
jebeck committed Apr 8, 2016
2 parents 8673868 + 2c66edb commit 1464e5c
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion lib/common.js
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,11 @@ module.exports = function (cfg, deps) {
if (usersToken == null) {
return null;
}
return makeUploadUrl('', { token: usersToken });
// We previously exposed the user's session id here - which we identified as a security risk.
// We would have just removed the token query param altogether, but the URl that we direct user's to
// is configured in a way where the token needs to be set for the Chrome Uploader to be launched
// So for now we are setting the token to a constant.
return makeUploadUrl('', { launchUploader: 'true' });
}
/**
* Set Blip host
Expand Down

0 comments on commit 1464e5c

Please sign in to comment.