Skip to content

Commit

Permalink
[WEB-2395] Add GA Measurement ID env variable to local Tilt builds (#230
Browse files Browse the repository at this point in the history
)

* Tiltfile: Allow adding google analytics 4 ID

* Tiltfile: Remove CLINICS_ENABLED flag
  • Loading branch information
clintonium-119 authored Jul 21, 2023
1 parent 92937a9 commit 21ca56d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Tiltconfig.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,7 @@ blip:
apiHost: 'http://localhost:31500'
realmHost: 'http://localhost:32000'
rollbarPostServerToken: '' # Rollbar post_server_item access token for posting source maps on production builds
reactAppGAID: '' # Google Analytics 4 ID
webpackDevTool: cheap-module-eval-source-map
webpackDevToolViz: cheap-source-map # Suggest changing `cheap-source-map` to the slower, but far more helpful `source-map` if debugging errors in viz package files
webpackPublicPath: 'http://localhost:31500/'
Expand Down Expand Up @@ -258,7 +259,6 @@ blip:
- ALL
# i18nEnabled: 'true' # Uncomment to enable internationalization UI
# rxEnabled: 'true' # Uncomment to enable prescriptions UI
# clinicsEnabled: 'true' # Uncomment to enable clinics UI
pendoEnabled: 'false' # Set to `true` to enable pendo
# disableDevTools: true # Uncomment if working with large data sets is sluggish in development build
# buildTarget: production # Uncomment to run minified production builds
Expand Down
4 changes: 2 additions & 2 deletions Tiltfile
Original file line number Diff line number Diff line change
Expand Up @@ -290,10 +290,10 @@ def applyServiceOverrides(tidepool_helm_template_cmd):
packageName=packageName,
)

buildCommand += ' --build-arg LINKED_PKGS={linkedPackages} --build-arg ROLLBAR_POST_SERVER_TOKEN={rollbarPostServerToken} --build-arg CLINICS_ENABLED={clinicsEnabled} --build-arg PENDO_ENABLED={pendoEnabled} --build-arg I18N_ENABLED={i18nEnabled} --build-arg RX_ENABLED={rxEnabled}'.format(
buildCommand += ' --build-arg LINKED_PKGS={linkedPackages} --build-arg ROLLBAR_POST_SERVER_TOKEN={rollbarPostServerToken} --build-arg REACT_APP_GAID={reactAppGAID} --build-arg PENDO_ENABLED={pendoEnabled} --build-arg I18N_ENABLED={i18nEnabled} --build-arg RX_ENABLED={rxEnabled}'.format(
linkedPackages=','.join(activeLinkedPackages),
rollbarPostServerToken=overrides.get('rollbarPostServerToken'),
clinicsEnabled=overrides.get('clinicsEnabled'),
reactAppGAID=overrides.get('reactAppGAID'),
pendoEnabled=overrides.get('pendoEnabled'),
i18nEnabled=overrides.get('i18nEnabled'),
rxEnabled=overrides.get('rxEnabled'),
Expand Down

0 comments on commit 21ca56d

Please sign in to comment.