Reduce the amount of redundant COUNT queries #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Small proposal for reducing the amount of
COUNTqueries when the result set is full already. Kinda hits performance.Currently, the paginator makes
COUNTquery for each request (unless the:countoption provided by user).On some big tables (millions records) with many filters it adds a lot to response time, as while the main result is limited by user defined limit params, like
page[:size], theCOUNTqueries are executed against the whole table.And it tends to be redundant if the amount of records returned for a query is already less than limit specified (as there won't be any more pages).