Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TokenCompleteTextView's "prevent free-form text" behavior #8733

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

cketti
Copy link
Member

@cketti cketti commented Jan 10, 2025

Fixes a bug that was introduced in 11b989e.

The code

if (preventFreeFormText || currentCompletionText().length() > 0) {
    // do thing
}

was replaced with

if (currentCompletionText().length() > 0) {
    // do thing
}

when it should have been

// do thing

because preventFreeFormText was always true.

Fixes #8732 (issue also contains instructions on how to reproduce)

@cketti cketti requested a review from wmontwe as a code owner January 10, 2025 17:09
Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cketti cketti merged commit dffd7ec into thunderbird:main Jan 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recipient field shows additional text after state restoration
2 participants