Show the "Use system default" theme option on pre API 28 devices #8713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmontwe
requested changes
Jan 7, 2025
There was a problem hiding this comment.
@Ephemera42 Thank you for simplifying the theme handling logic. I tested the behavior on API levels 21-27 and did not find any side effects.
Do you maybe know how to enforce night mode before API level 28?
Please also remove the remaining theme_values_legacy array.
Remove unused array
Ephemera42
force-pushed
the
follow-system-theme-on-pre-api-28-devices
branch
from
e1205f4 to
cfc524e
Compare
You can use the
Fixed now, thanks for reminding me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android Night Mode was introduced in API 8, which enables automatic switching between day and night modes. Therefore, the follow system theme option is available on pre API 28 devices.
output.webm