-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build & Sign Automation #8192
Merged
Merged
Build & Sign Automation #8192
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,230 @@ | ||
name: Shippable Build & Signing | ||
on: | ||
workflow_dispatch: | ||
|
||
jobs: | ||
get_environment: | ||
runs-on: ubuntu-latest | ||
outputs: | ||
releaseEnv: ${{ steps.getReleaseEnv.outputs.result }} | ||
steps: | ||
- uses: actions/github-script@v7 | ||
id: getReleaseEnv | ||
with: | ||
result-encoding: string | ||
script: | | ||
const RELEASE_ENVS = { | ||
"refs/heads/main": "thunderbird_daily", | ||
"refs/heads/beta": "thunderbird_beta", | ||
"refs/heads/release": "thunderbird_release", | ||
}; | ||
|
||
if (context.ref in RELEASE_ENVS) { | ||
return RELEASE_ENVS[context.ref]; | ||
} else { | ||
core.setFailed(`Unknown branch ${context.ref} for shippable builds!`) | ||
return ""; | ||
} | ||
|
||
dump_config: | ||
runs-on: ubuntu-latest | ||
needs: get_environment | ||
environment: ${{ needs.get_environment.outputs.releaseEnv }} | ||
outputs: | ||
matrixInclude: ${{ vars.MATRIX_INCLUDE }} | ||
appName: ${{ vars.APP_NAME }} | ||
releaseType: ${{ vars.RELEASE_TYPE }} | ||
tagPrefix: ${{ vars.TAG_PREFIX }} | ||
steps: | ||
- name: Dump Vars context | ||
id: variables | ||
env: | ||
VARS_CONTEXT: ${{ toJSON(vars) }} | ||
MATRIX_INCLUDE: ${{ vars.MATRIX_INCLUDE }} | ||
run: | | ||
echo "$VARS_CONTEXT" | ||
echo "$MATRIX_INCLUDE" | ||
|
||
|
||
build_unsigned: | ||
runs-on: ubuntu-latest | ||
timeout-minutes: 90 | ||
needs: [dump_config, get_environment] | ||
strategy: | ||
matrix: | ||
include: "${{ fromJSON(needs.dump_config.outputs.matrixInclude) }}" | ||
environment: ${{ needs.get_environment.outputs.releaseEnv }} | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Copy CI gradle.properties | ||
shell: bash | ||
run: mkdir -p ~/.gradle ; cp .github/ci-gradle.properties ~/.gradle/gradle.properties | ||
|
||
- uses: actions/setup-java@v4 | ||
with: | ||
distribution: temurin | ||
java-version: 17 | ||
|
||
- name: Setup Gradle | ||
uses: gradle/actions/setup-gradle@v4 | ||
|
||
- name: Build It | ||
shell: bash | ||
env: | ||
PACKAGE_FORMAT: ${{ matrix.packageFormat }} | ||
PACKAGE_FLAVOR: ${{ matrix.packageFlavor }} | ||
APP_NAME: ${{ vars.APP_NAME }} | ||
RELEASE_TYPE: ${{ vars.RELEASE_TYPE }} | ||
run: | | ||
BUILD_CMD="${PACKAGE_FORMAT}" | ||
if [[ "$PACKAGE_FORMAT" = "apk" ]]; then | ||
BUILD_CMD="assemble" | ||
fi | ||
# ^ upper-case first character of bash string | ||
BUILD_COMMAND="${BUILD_CMD}${PACKAGE_FLAVOR^}${RELEASE_TYPE^}" | ||
echo "BUILDING: :${APP_NAME}:${BUILD_COMMAND}" | ||
./gradlew clean :${APP_NAME}:${BUILD_COMMAND} --no-build-cache --no-configuration-cache | ||
echo "Status: $?" | ||
|
||
- name: Move apps to upload directory | ||
shell: bash | ||
env: | ||
PACKAGE_FORMAT: ${{ matrix.packageFormat }} | ||
PACKAGE_FLAVOR: ${{ matrix.packageFlavor }} | ||
APP_NAME: ${{ vars.APP_NAME }} | ||
RELEASE_TYPE: ${{ vars.RELEASE_TYPE }} | ||
OUT_BASE: ${{ vars.APP_NAME }}/build/outputs/${{ matrix.packageFormat }} | ||
UPLOAD_PATH: "uploads" | ||
run: | | ||
mkdir -p "${UPLOAD_PATH}" | ||
if [[ "${PACKAGE_FORMAT}" = "apk" ]]; then | ||
OUT_PATH="${OUT_BASE}/${PACKAGE_FLAVOR}/${RELEASE_TYPE}" | ||
OUT_FILE="${APP_NAME}-${PACKAGE_FLAVOR}-${RELEASE_TYPE}-unsigned.apk" | ||
RENAMED_FILE="${OUT_FILE/-unsigned/}" | ||
elif [[ "${PACKAGE_FORMAT}" = "bundle" ]]; then | ||
OUT_PATH="${OUT_BASE}/${PACKAGE_FLAVOR}${RELEASE_TYPE^}" | ||
OUT_FILE="${APP_NAME}-${PACKAGE_FLAVOR}-${RELEASE_TYPE}.aab" | ||
RENAMED_FILE="${OUT_FILE}" | ||
else | ||
echo "PACKAGE_FORMAT $PACKAGE_FORMAT is unknown. Exiting." | ||
exit 23 | ||
fi | ||
if [[ -f "${OUT_PATH}/${OUT_FILE}" ]]; then | ||
mv -f "${OUT_PATH}/${OUT_FILE}" "${UPLOAD_PATH}/${RENAMED_FILE}" | ||
else | ||
echo "Build file ${OUT_PATH}/${OUT_FILE} not found. Exiting." | ||
ls -l ${OUT_PATH} | ||
exit 24 | ||
fi | ||
echo "Upload contents:" | ||
ls -l ${UPLOAD_PATH}/ | ||
|
||
- name: Upload unsigned | ||
uses: actions/upload-artifact@v4 | ||
env: | ||
UPLOAD_PATH: "uploads" | ||
with: | ||
name: unsigned-${{ vars.APP_NAME}}-${{ matrix.packageFormat }}-${{ matrix.packageFlavor }} | ||
path: ${{ env.UPLOAD_PATH }}/ | ||
if-no-files-found: error | ||
|
||
sign_mobile: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
include: "${{ fromJSON(needs.dump_config.outputs.matrixInclude) }}" | ||
environment: ${{ needs.dump_config.outputs.appName }}_${{ needs.dump_config.outputs.releaseType }}_${{ matrix.packageFlavor }} | ||
needs: [build_unsigned, dump_config] | ||
env: | ||
APP_NAME: ${{ needs.dump_config.outputs.appName }} | ||
RELEASE_TYPE: ${{ needs.dump_config.outputs.releaseType }} | ||
steps: | ||
- uses: actions/download-artifact@v4 | ||
with: | ||
name: unsigned-${{ env.APP_NAME }}-${{ matrix.packageFormat }}-${{ matrix.packageFlavor }} | ||
path: uploads/ | ||
|
||
- uses: noriban/sign-android-release@5f144321d3c7c2233266e78b42360345d8bbe403 # v5.1 | ||
name: Sign package | ||
with: | ||
releaseDirectory: uploads/ | ||
signingKeyBase64: ${{ secrets.SIGNING_KEY }} | ||
alias: ${{ secrets.KEY_ALIAS }} | ||
keyPassword: ${{ secrets.KEY_PASSWORD }} | ||
keyStorePassword: ${{ secrets.KEY_STORE_PASSWORD }} | ||
|
||
- name: Remove JKS file | ||
shell: bash | ||
run: | | ||
rm -f uploads/*.jks | ||
|
||
- name: Upload signed | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: signed-${{ env.APP_NAME}}-${{ matrix.packageFormat }}-${{ matrix.packageFlavor }} | ||
if-no-files-found: error | ||
path: | | ||
uploads/*-signed.apk | ||
uploads/*.aab | ||
jfx2006 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
pre_publish: | ||
# This is a holding job meant to require approval before proceeding with the publishing jobs below | ||
# The environment has a deployment protection rule requiring approval from a set of named reviewers | ||
# before proceeding. | ||
environment: publish_hold | ||
needs: [sign_mobile] | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Approval | ||
shell: bash | ||
run: | | ||
true | ||
|
||
github_release: | ||
runs-on: ubuntu-latest | ||
needs: [ pre_publish, dump_config ] | ||
environment: gh-releases | ||
env: | ||
APP_NAME: ${{ needs.dump_config.outputs.appName }} | ||
RELEASE_TYPE: ${{ needs.dump_config.outputs.releaseType }} | ||
TAG_PREFIX: ${{ needs.dump_config.outputs.tagPrefix }} | ||
PACKAGE_FORMAT: "apk" | ||
PACKAGE_FLAVOR: "foss" | ||
UPLOADS: "uploads" | ||
steps: | ||
- uses: actions/download-artifact@v4 | ||
with: | ||
# The artifact name is the APK FOSS package for Github releases | ||
kewisch marked this conversation as resolved.
Show resolved
Hide resolved
|
||
name: signed-${{ env.APP_NAME }}-${{ env.PACKAGE_FORMAT }}-${{ env.PACKAGE_FLAVOR }} | ||
path: ${{ env.UPLOADS }}/ | ||
|
||
- name: Get Tag Name | ||
## This obviously is quite incorrect. Need a way to extract versionName from gradle | ||
kewisch marked this conversation as resolved.
Show resolved
Hide resolved
|
||
shell: bash | ||
run: | | ||
APKANALYZER="${ANDROID_SDK_ROOT}/cmdline-tools/latest/bin/apkanalyzer" | ||
APK_FILE="${APP_NAME}-${PACKAGE_FLAVOR}-${RELEASE_TYPE}-signed.apk" | ||
_version=$(${APKANALYZER} manifest version-name "${UPLOADS}/${APK_FILE}") | ||
_tag="${TAG_PREFIX}_${_version//./_}" | ||
echo "Tag Name: ${_tag}" | ||
echo "Apk File: ${APK_FILE}" | ||
echo "TAG_NAME=${_tag}" >> $GITHUB_ENV | ||
kewisch marked this conversation as resolved.
Show resolved
Hide resolved
|
||
echo "APK_FILE=${APK_FILE}" >> $GITHUB_ENV | ||
|
||
- name: App Token Generate | ||
uses: actions/create-github-app-token@v1 | ||
id: app-token | ||
with: | ||
app-id: ${{ vars.RELEASER_APP_CLIENT_ID }} | ||
private-key: ${{ secrets.RELEASER_APP_PRIVATE_KEY }} | ||
|
||
- name: Publish | ||
uses: softprops/action-gh-release@v2 | ||
with: | ||
token: ${{ steps.app-token.outputs.token }} | ||
target_commitish: ${{ github.sha }} | ||
tag_name: ${{ env.TAG_NAME }} | ||
fail_on_unmatched_files: true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add Now the release emails I receive have no notes, please fix this 😢 |
||
files: | | ||
${{ env.UPLOADS }}/${{ env.APK_FILE }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
# Release Automation Setup | ||
|
||
Release automation is triggered by the workflow_dispatch event on the "Shippable Build & Signing" | ||
workflow. | ||
|
||
GitHub environments are used to set configuration variables for each application | ||
and release type. The environment is selected when triggering the workflow. You must | ||
also select the appropriate branch to run the workflow on. The environments are only | ||
accessible by the branch they are associated with | ||
|
||
## Build Environments | ||
|
||
- thunderbird_beta | ||
- thunderbird_daily | ||
- thunderbird_release | ||
- thunderbird_debug | ||
|
||
The variables set in these environments are non-sensitive and are used by the build job. | ||
|
||
- APP_NAME: app-thunderbird | app-k9 | ||
- TAG_PREFIX: THUNDERBIRD | K9MAIL | ||
- RELEASE_TYPE: debug | daily | beta | release | ||
- MATRIX_INCLUDE: | ||
- This is a JSON string used to create the jobs matrix. For example, for | ||
Thunderbird beta, the (YAML) value would be: | ||
```yaml | ||
- packageFormat: bundle | ||
packageFlavor: full | ||
- packageFormat: apk | ||
packageFlavor: foss | ||
``` | ||
That would build `bundleFullBeta` and `assembleFossBeta`. | ||
|
||
## Signing Environments | ||
|
||
There are also "secret" environments that are used by the signing job. | ||
|
||
An "upload" secret environment and a "signing" secret environment are needed. Currently the environment names are based | ||
on the appName, releaseType, and packageFlavor. So `app-thunderbird_beta_full` which would have the upload | ||
signing configuration for Thunderbird Beta set up. This could be improved. | ||
The secrets themselves are from https://github.com/noriban/sign-android-release: | ||
|
||
```yaml | ||
signingKey: ${{ secrets.SIGNING_KEY }} | ||
alias: ${{ secrets.KEY_ALIAS }} | ||
keyPassword: ${{ secrets.KEY_PASSWORD }} | ||
keyStorePassword: ${{ secrets.KEY_STORE_PASSWORD }} | ||
``` | ||
|
||
## Publishing Hold Environment | ||
|
||
The "publish_hold" is shared by all application variants and is used by the "pre_publish" job. | ||
It has no secrets or variables, but "Required Reviewers" is set to trusted team members who oversee releases. The | ||
effect is that after package signing completes, the publishing jobs that depend on it will not run until released | ||
manually. | ||
|
||
![publish hold](publish_hold.png) | ||
|
||
## Github Releases Environment | ||
|
||
"gh_releases" contains the Client Id and Private Key for a Github App that's used by the "actions/create-github-app-token' | ||
to generate a token with the appropriate permissions to create and tag a Github release. | ||
|
||
| | Name | Description | | ||
| -------- | ------------------------ | ------------------------------- | | ||
| Variable | RELEASER_APP_CLIENT_ID | The Client ID of the github app | | ||
| Secret | RELEASER_APP_PRIVATE_KEY | The private key of the app | | ||
|
||
### App Permissions | ||
|
||
**TODO** |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we use
${{ needs.get_environment.outputs.releaseEnv }}
here and depend on get_environment as well?