-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix permission screen back behavior #7496
Conversation
When account setup is complete, all screens should probably also be popped off the back stack. |
95b596f
to
7635044
Compare
I changed it to pop the back stack, but the behavior is now: press back -> leave app -> enter app again -> permission screen is gone and you land in the inbox. VS old: press back -> nothing happens -> skip or grant notification permission and continue with the onboarding So the question is what is the intended behavior? |
My suggestion would be: |
a) this screen is only shown on first use of the app |
I meant when a user used the permission screen to grant the permissions, then instead of using the "Next" button they (maybe accidentally) use the back button.
I am aware. We could add one. It's an edge case users should rarely run into. Anyway, this could be a "proper" fix for later. For now we could just do what you initially had (ignore the back button). My suggestion was to pop the back stack in addition to that. Both to free resources and so we can't accidentally leave another way open to navigate back to the account setup screens. |
7635044
to
8259a8d
Compare
Prevent back navigation on permission screen to not create accounts twice or get stuck on the account created screen.