Add check to prevent the use of IP addresses as SNI hostnames #7483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3676 (kind of).
When I attempt to add my mail server using a literal IPv6 address, I get the following error:
Screenshot
The error occurs because the constructor of
javax.net.ssl.SNIHostName
fails to parse the hostname. This behavior is consistent with RFC 6066, which explicitly prohibits using literal IPv4 or IPv6 addresses as SNI hostnames.This PR fixes the problem by adding the corresponding check before setting the SNI hostname for the SSL/TLS connection.
The other problems mentioned in the original issue are no longer relevant, since the server settings validator was recently updated to accept literal IPv6 addresses.