Disable autocorrect in server settings input fields

[bernhard-fp]

Set textfield inputtypes to textNoSuggestions

First pull-request.
I hope I have understood the ticket correctly.

Fixes #7361

[cketti]

Welcome @bernhard-fp 👋

Thanks for wanting to contribute.

We're currently rewriting the account setup using Jetpack Compose. The new code can be found here:

• https://github.com/thunderbird/thunderbird-android/blob/main/feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/incoming/IncomingServerSettingsScreen.kt
• https://github.com/thunderbird/thunderbird-android/blob/main/feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/outgoing/OutgoingServerSettingsScreen.kt

The layout you've changed will be removed soon. So, sadly, this is not what we're looking for.

Issue #7361 contains a comment with links to the relevant documentation for Compose. Since we're wrapping Material composables to create our own design system, support for being able to specify KeyboardOptions has to be added in the module :core:ui:compose:designsystem first, e.g. TextFieldOutlined. Then the screens for incoming and outgoing server settings can be changed to make use of that new feature.

[bernhard-fp]

@cketti Thank you. So I think I can start adding a new value keyboardOptions to IncomingFormItems->TextInput and set the autoCorrect value to false in the both screens you mentioned.
Per default it would be KeyboardOptions()

[cketti]

You should be able to copy the approach from one of the Material Composables we're wrapping, e.g.
https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt;l=149;drc=0ea8ee615a4f669d7ecfbcb657704a937fb5129d

Using KeyboardOptions.Default will avoid having to create a new instance when you don't want to override the default behavior.

[bernhard-fp]

Hi @cketti, I reverted this first commit and added the KeyboardOptions to the belonging classes.
Unfortunately I can not test because on my Pixel7 and on my emulator I do not see any auto corrections.
But now autoCorrect=false is explicitly set.
Thanks for reviewing :-)

[bernhard-fp]

Ok, added the change to both (incoming and outgoing)

[bernhard-fp]

@cketti Could you please test if it matches the desired functionality?

[cketti]

Almost there 👍

Note: After changing a pull request, it's usually a good idea to do a self review to see if you missed something (like applying a change to all occurrences of a particular pattern).

[bernhard-fp]

@cketti Yes, I must have lost a bit of concentration there :-)
Did the changes you mentioned.

[cketti]

Thanks 👍

In the future please don't update a pull request branch by merging main (or any other branch) into it. That makes it unnecessarily hard to clean up the history before merging.
(This is also mentioned in the pull request template.)