Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enabled state to AccountOAuthView #7344

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

wmontwe
Copy link
Member

@wmontwe wmontwe commented Nov 9, 2023

This adds enabled state to AccountOAuthView used by AutoDisccovery to disable the sign in button in case configuration is not trusted.

This also adds visual disabled state to SignInWithGoogleButton:

Before:

old_disabled_state

After:

new_disabled_state

@wmontwe wmontwe requested a review from cketti November 9, 2023 10:22
@wmontwe wmontwe force-pushed the add_disabled_state_to_oauth_view branch from b7dda80 to 9faaf96 Compare November 9, 2023 12:37
@wmontwe wmontwe merged commit 5e45264 into main Nov 9, 2023
2 checks passed
@wmontwe wmontwe deleted the add_disabled_state_to_oauth_view branch November 9, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants