-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement warning to make users aware of the missing check #214
Conversation
We are not currently capable of checking Python version specifiers from Poetry specification because it's very complex. And right now it's better to warn users about it than do nothing.
Implement or use external parser for Python versions in Poetry specification.Lines 653 to 658 in 9919e28
This comment was generated by todo based on a
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment, otherwise LGTM. Thanks! 👍🏻 (as it is Friday, I might revisit the review on Monday -- tired eyes 👼🏻 ).
Co-authored-by: Fridolín Pokorný <[email protected]>
Applied, thanks a lot for the quick review, and feel free to leave the rest for Monday. We should also merge it manually to be able to squash it first. |
LGTM, thanks! 👍🏻 |
We are not currently capable of checking Python version specifiers
from Poetry specification because it's very complex. And right now
it's better to warn users about it than do nothing.
Related Issues and Dependencies
#187
This introduces a breaking change