Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement warning to make users aware of the missing check #214

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

frenzymadness
Copy link
Collaborator

We are not currently capable of checking Python version specifiers
from Poetry specification because it's very complex. And right now
it's better to warn users about it than do nothing.

Related Issues and Dependencies

#187

This introduces a breaking change

  • Yes
  • No

We are not currently capable of checking Python version specifiers
from Poetry specification because it's very complex. And right now
it's better to warn users about it than do nothing.
@todo
Copy link

todo bot commented Dec 3, 2021

Implement or use external parser for Python versions in Poetry specification.

micropipenv/micropipenv.py

Lines 653 to 658 in 9919e28

# TODO: Implement or use external parser for Python versions in Poetry specification.
# See for details: https://github.com/thoth-station/micropipenv/issues/187
current_python_version = "{}.{}".format(sys.version_info.major, sys.version_info.minor)
wanted_python_version = poetry_lock["metadata"]["python-versions"]
message = (
"Warning: Currently, Micropipenv is not able to parse complex Python version specifications used by Poetry. "


This comment was generated by todo based on a TODO comment in 9919e28 in #214. cc @frenzymadness.

@sesheta
Copy link
Member

sesheta commented Dec 3, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from frenzymadness after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta requested a review from KPostOffice December 3, 2021 16:04
@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 3, 2021
Copy link
Collaborator

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, otherwise LGTM. Thanks! 👍🏻 (as it is Friday, I might revisit the review on Monday -- tired eyes 👼🏻 ).

micropipenv.py Outdated Show resolved Hide resolved
Co-authored-by: Fridolín Pokorný <[email protected]>
@frenzymadness
Copy link
Collaborator Author

Applied, thanks a lot for the quick review, and feel free to leave the rest for Monday. We should also merge it manually to be able to squash it first.

@fridex
Copy link
Collaborator

fridex commented Dec 6, 2021

LGTM, thanks! 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants