Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update init.pp #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

schlitzered
Copy link

Some sysctl values return "tabs", this breakes the test for changes, since there is no sane way to specify tabs in the target value.

this change converts tabs in the output of sysctl -n to two spaces. resolving this issue of false positive change detection

Some sysctl values return "tabs", this breakes the test for changes, since there is no sane way to specify tabs in the target value.

this change converts tabs in the output of sysctl -n to two spaces. resolving this issue of false positive change detection
@fetzerms
Copy link

fetzerms commented Feb 7, 2022

@thias this PR is now over a year old. Do you think there is a chance to get it merged?

@bschonec
Copy link

bschonec commented Jun 14, 2022

I ran Puppet with your updates and it did not fix:

kernel.sem
net.ipv4.ip_local_port_range
net.ipv4.route.flush

If I change the sed tab-replace line to substitue one space instead of two spaces, then only net.ipv4.route.flush is broken.

I'll look into the code to see if there's more needed to fix the net.ipv4.route.flush.

@bschonec
Copy link

net.ipv4.route.flush isn't something that Puppet should manage because it's not a setting but more of a method to clear the routing table (and hence causes a change).

I've submitted schlitzered#1 to THIS pull request to fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants