-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Puppet v4 #51
base: master
Are you sure you want to change the base?
Conversation
Modernize module * Drop support for Puppet v2. * Add support for Puppet v4. * Explicitly test against supported Ruby and Puppet matrix. * Support Ruby versions 1.8.7, 1.9.3, 2.0.0, 2.1.0 and 2.3.1. * Use puppet-lint v2. * Use community puppet-lint plugins (Code already complied with the style).
Hi @thias could you please merge this |
Hello Great job, I need this feature too :) Regards |
Hej @thias, Please give it a try :) |
If you are interessted in this, I can add the needed changes to keep this running with the latest Puppets and gem versions. |
@Phil-Friderici I would be happy to accept those in my branch if you would like to submit a PR against that. |
@ghoneycutt sent a PR to your branch @thias my repo has Travis CI enabled and you can have a peek how a PR will looks like with it [1] and what nice overview you get about the tested combinations of Puppet and Ruby [2]. [1] Phil-Friderici#1 |
Update testing rig for Puppet 4.10
Modernize module
Drop support for Puppet v2.
Add support for Puppet v4.
Explicitly test against supported Ruby and Puppet matrix.
Support Ruby versions 1.8.7, 1.9.3, 2.0.0, 2.1.0 and 2.3.1.
Use puppet-lint v2.
Use community puppet-lint plugins (Code already complied with the
style).