Reorganize Delegate panel links #10651
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Moves the Delegate Handbook link to the Important Links section 2. Removes the "All Delegates" link from the Delegate panel, because it is not necessary or useful here 3. Adds sections to the Important Links so that they are better organized
nsilvestri
force-pushed
the
delegate-panel-ui
branch
from
830a61b to
15e2dfb
Compare
gregorbg
requested changes
Jan 20, 2025
Comment on lines
+43
to
+44
| const DELEGATE_HANDBOOK_LINK = | ||
| 'https://documents.worldcubeassociation.org/edudoc/delegate-handbook/delegate-handbook.pdf'; |
There was a problem hiding this comment.
Where is this constant being used. if you're deleting the delegateHandbook panel page further down?
(Sorry if this question is obvious, I just can't see it from the way GitHub renders the diff of this particular PR)
Comment on lines
+64
to
+71
| <div key={section}> | ||
| <Header as='h3'>{section}</Header> | ||
| <List> | ||
| {links.map(({ title, link }) => ( | ||
| <ListItemLink key={link} title={title} link={link} /> | ||
| ))} | ||
| </List> | ||
| </div> |
There was a problem hiding this comment.
Not too fond of "wild" divs appearing in our codebase. Lists in Semantic UI can do sub-lists, have you considered that?
There was a problem hiding this comment.
Otherwise, React.Fragment should do as a last resort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit:
There's still some jank with the CSS but this page wasn't pretty anyway and I don't want to mess with the styling rn
Desktop View:
Mobile View: