feat: Tap 4 Implementation (TUFClient interface) #431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had some issues rebasing with just these commits as I had already started to implement some of your suggestions locally, hence the new PR. |
asraa
previously approved these changes
Nov 8, 2022
dibrinsofor
requested review from
asraa and
znewman01
and removed request for
asraa and
znewman01
asraa
previously approved these changes
Nov 16, 2022
trishankatdatadog
force-pushed
the
master
branch
from
1485d0c
to
57dad58
Compare
znewman01
previously approved these changes
Nov 18, 2022
|
This looks good expect for two things:
|
dibrinsofor
requested review from
znewman01 and
asraa
and removed request for
znewman01 and
asraa
znewman01
previously approved these changes
Dec 23, 2022
trishankatdatadog
force-pushed
the
master
branch
from
d82c38a
to
d6276c8
Compare
|
Sorry about this @dibrinsofor but can you rebase? We can do a quick re-review, should be an easy change then. |
dibrinsofor
force-pushed
the
master
branch
2 times, most recently
from
b9a5740
to
b068fab
Compare
|
@znewman01 all done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #348
Release Notes:
Types of changes:
!, as infeat!: change foo).Description of the changes being introduced by the pull request: Began abstracting Client into interface in interface.go for future use towards multi-client mapping. currently setup with Update, Download, VerifyDigest, Target and Targets functionality. with @znewman01 and @vaikas
Please verify and check that the pull request fulfills the following requirements: