WIP: Support delegated targets roles in repo writer #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethan-lowman-dd
commented
Nov 4, 2021
There was a problem hiding this comment.
Copying over some comments from a previous draft branch
From @asraa (original comment)
fileSystemStore.GetMeta() topLevelMetadata loop doesn't account for the delegated roles
| t.Delegations = &data.Delegations{} | ||
| } | ||
|
|
||
| t.Delegations.Keys = make(map[string]*data.PublicKey) |
There was a problem hiding this comment.
From @asraa (original comment)
this will nuke the delegations keys on repeated calls to AddTargetsDelegations, so this hsould move into the t.Delegations == nil branch
| } | ||
| } | ||
|
|
||
| t.Delegations.Roles = append(t.Delegations.Roles, role) |
There was a problem hiding this comment.
From @asraa (original comment)
this won't check for dupes, so maybe this should have a loop that replace the role if the rolename is repeated or something
hosseinsia
requested review from
hosseinsia,
trishankatdatadog,
asraa and
erickt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.