Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support modifying role thresholds #135

Merged
merged 4 commits into from
Jun 30, 2021
Merged

Support modifying role thresholds #135

merged 4 commits into from
Jun 30, 2021

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Jun 24, 2021 •
edited
Loading

Adds the ability to modify role thresholds in the CLI

Fixes #6

Question: are there CLI tests?

Signed-off-by: Asra Ali [email protected]

mnm678
mnm678 reviewed Jun 24, 2021
View reviewed changes
Copy link
Collaborator

@mnm678 mnm678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My go skills are a bit rusty (no pun intended), but this looks good to me. There's a couple of bits that would need to change for delegations, but I don't think that's a blocker.

repo.go Show resolved Hide resolved
repo_test.go Show resolved Hide resolved
repo.go Show resolved Hide resolved
@asraa
add getter
7681f96 
Signed-off-by: Asra Ali <[email protected]>
@asraa
error condition when delegation
6b6273e 
Signed-off-by: Asra Ali <[email protected]>
@asraa
fix valid manifest
f29eec5 
Signed-off-by: Asra Ali <[email protected]>
trishankatdatadog
trishankatdatadog approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@trishankatdatadog trishankatdatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice functionality, thanks! Clearly the code will need to change when we add delegations, but this is very much needed.

repo.go Show resolved Hide resolved
repo_test.go Show resolved Hide resolved
@trishankatdatadog
Copy link
Member

I am happy with merging. Marina?

@mnm678
Copy link
Collaborator

mnm678 commented Jun 30, 2021

I am happy with merging. Marina?

LGTM, but I'm not a maintainer

@trishankatdatadog trishankatdatadog merged commit 22a9481 into theupdateframework:master Jun 30, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 978833412

  • 19 of 34 (55.88%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 67.393%
Changes Missing Coverage Covered Lines Changed/Added Lines %
repo.go 19 34 55.88%
Totals Coverage Status
Change from base Build 453172856: 0.2%
Covered Lines: 1577
Relevant Lines: 2340
💛 - Coveralls

mnm678 pushed a commit to mnm678/go-tuf that referenced this pull request Oct 21, 2021
@asraa @mnm678
Support modifying role thresholds (theupdateframework#135)
c12c9d3 
* Support modifying role thresholds

Signed-off-by: Asra Ali <[email protected]>

* add getter

Signed-off-by: Asra Ali <[email protected]>

* error condition when delegation

Signed-off-by: Asra Ali <[email protected]>

* fix valid manifest

Signed-off-by: Asra Ali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trishankatdatadog trishankatdatadog trishankatdatadog approved these changes

@mnm678 mnm678 mnm678 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support modifying role thresholds via the CLI
4 participants
@asraa @trishankatdatadog @mnm678 @coveralls