smart-amp-test: remove obsolete build options #9773
Conversation
smart-amp-test was one of the first modules, used as an example for loadable module development. Currently it can be built in 4 ways: - monolithic - as an LMDK native module - as legacy LLEXT - as current LLEXT This commit removes legacy options and only preserves the first and the last options. Signed-off-by: Guennadi Liakhovetski <[email protected]>
|
@abonislawski whats happening with LMDK these days now that we can do llext ? Can we support LMDK APIs and loading via llext ? |
lyakh
requested review from
RanderWang,
marcinszkudlinski,
pblaszko,
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
|
@lgirdwood we are only keeping one LMDK module (downmixer) in CI just in case if something change in the future roadmap. But in general it is frozen and we can remove smart-amp |
|
CI: https://sof-ci.01.org/sofpr/PR9773/build10155/devicetest/index.html , https://sof-ci.01.org/sofpr/PR9773/build10157/devicetest/index.html and https://sof-ci.01.org/sofpr/PR9773/build10156/devicetest/index.html - all errors are known: missing test devices and a failure in suspend-resume. |
| @@ -15,7 +15,7 @@ SECTIONS { | |||
| _data_end = ABSOLUTE(.); | |||
| } >HPSRAM_seg : data_phdr | |||
|
|
|||
| .rodata : ALIGN(4096) { | |||
| .rodata : { | |||
There was a problem hiding this comment.
? Thhis seems very odd in a PR to remove smart-ampt-test
| #include <sof/compiler_attributes.h> | ||
| #endif |
There was a problem hiding this comment.
This too, is this removing more?
There was a problem hiding this comment.
@lyakh But smart-ampt-test was an example, wouldn't these changed be needed by other LMDK modules? OTOH, the CI tests seem to pass (there's at least the mixer module), so maybe these were needed just for smart-amp-test and not LMDK support in general. Just not so easy to make this conclusion from the diff.
There was a problem hiding this comment.
@kv2019i that's also my understanding, that since these changes were introduced with the smart-amp-test and reverting them doesn't break QB tests, don't think they were needed for other LMDK examples, i.e. for the down-mixer
smart-amp-test was one of the first modules, used as an example for loadable module development. Currently it can be built in 4 ways:
This commit removes legacy options and only preserves the first and the last possibilities.