IPC: Increase SOF_IPC_MSG_MAX_SIZE for testbench and unit test #9402
Conversation
The testbench and unit tests use a simplified simulated IPC that currently doesn't support messages split to multiple parts. As workaround to unblock other SOF development the size is increased from 384 bytes to 8192 bytes. This allows run of current test set with scripts/host-testbench.sh that is also used in SOF CI. The change can be reverted after the capability is added to testbench. Signed-off-by: Seppo Ingalsuo <[email protected]>
|
@cujomalainey This is other approach to fix the issue found with #9374. I didn't like the loss of tests coverage with #9391, and implementing multi-part binary control IPC to testbench isn't very straightforward. We are missing them from IPC4 testbench and SOF plugin as well. It's coming but likely not in a week or two. |
singalsu
requested review from
RanderWang,
marcinszkudlinski and
pblaszko
as code owners
| @@ -331,6 +331,8 @@ struct ipc_cmd_hdr; | |||
| /** Maximum message size for mailbox Tx/Rx */ | |||
| #if CONFIG_IPC_MAJOR_4 | |||
| #define SOF_IPC_MSG_MAX_SIZE 0x1000 | |||
| #elif CONFIG_LIBRARY_STATIC || UNIT_TEST | |||
| #define SOF_IPC_MSG_MAX_SIZE 0x2000 | |||
There was a problem hiding this comment.
How much do we care about the unit tests and libraries actually test IPC? If we care a lot then we should make this at best temporary.
There was a problem hiding this comment.
Unit tests and testbench bypass most of the IPC code. The SOF plugin and testbench IPC version (still a draft PR) are using the IPC library code so they would add coverage once they are ready for usage. In short term for unit tests and testbench I don't want to care much about IPC coverage but with the new frameworks I hope it gets better.
|
BTW Should this |
yes, thanks for pointing that out, we can reduce it to the ipc window size. 4096 i think is ipc4, but 3 is only 384 |
Nice coincidence: I'm just adding new |
The testbench and unit tests use a simplified simulated IPC that currently doesn't support messages split to multiple parts. As workaround to unblock other SOF development the size is increased from 384 bytes to 8192 bytes.
This allows run of current test set with scripts/host-testbench.sh that is also used in SOF CI. The change can be reverted after the capability is added to testbench.