zephyr: pm_runtime: Remove outdated TODO comment #8893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmleman
requested review from
kv2019i,
lyakh,
iuliana-prodan,
dbaluta and
abonislawski
as code owners
Clean up an incorrect TODO comment in the power management runtime policy. The removed comment suggested the need for substates to handle cases where power gating (PG) is enabled and clock gating (CG) is disabled. However, this is not accurate because: - Enabling PG when CG is not allowed is not feasible; entering PG could inadvertently gate the clock even if CG prevent is active. - Substates are no longer required as clock gating is now always enabled. This change clarifies the power management behavior and removes confusion around the handling of power and clock gating. Signed-off-by: Tomasz Leman <[email protected]>
lgirdwood
approved these changes
Mar 1, 2024
dbaluta
approved these changes
Mar 4, 2024
kv2019i
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up an incorrect TODO comment in the power management runtime policy.
The removed comment suggested the need for substates to handle cases where power gating (PG) is enabled and clock gating (CG) is disabled. However, this is not accurate because:
This change clarifies the power management behavior and removes confusion around the handling of power and clock gating.