Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Topology2: No need for HDA platform variants for benchmark tplg #8885

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

singalsu
Copy link
Collaborator

Since there is no NHLT blob included to these topologies, the same topology works for all HDA platforms, e.g. TGL, MTL, LNL.

Since there is no NHLT blob included to these topologies, the same
topology works for all HDA platforms, e.g. TGL, MTL, LNL.

Signed-off-by: Seppo Ingalsuo <[email protected]>
@singalsu singalsu requested a review from ujfalusi February 27, 2024 12:42
@singalsu singalsu marked this pull request as ready for review February 27, 2024 12:45
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@singalsu not following the commit message, whats the change in output from the Makefile after this change.

@singalsu
Copy link
Collaborator Author

@singalsu not following the commit message, whats the change in output from the Makefile after this change.

There won't be after this separate tgl/mtl versions of the topology. E.g. "sof-hda-benchmark-gain32-mtl.tplg" and "sof-hda-benchmark-gain32-tgl.tplg" are the same topology (no binary differences), so the new name is just "sof-hda-benchmark-gain32.tplg". Doing the duplicates was my misunderstanding. I realized from Peter's cleanup work that the topologies without NHLT are common for all platforms.

@lgirdwood
Copy link
Member

@ujfalusi pls review.

@kv2019i kv2019i merged commit 259c923 into thesofproject:main Mar 5, 2024
37 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants