Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST][Do not review] Test some 16b DMIC topologies #8883

Closed
wants to merge 8 commits into from

Conversation

singalsu
Copy link
Collaborator

No description provided.

@singalsu singalsu requested a review from fredoh9 February 26, 2024 16:12
@singalsu singalsu force-pushed the lnl_with_16bit_dmic branch from 40360aa to a254e16 Compare February 28, 2024 15:36
@ranj063
Copy link
Collaborator

ranj063 commented Feb 28, 2024

@singalsu you're going to need this linux PR to make your PR work thesofproject/linux#4840

@plbossart
Copy link
Member

Not following his one either, are we trying to enable 16-bit DMIC for production topologies or just internal tests with development topologies?

@singalsu
Copy link
Collaborator Author

Not following his one either, are we trying to enable 16-bit DMIC for production topologies or just internal tests with development topologies?

This is needed for test with a new platform. The reference blobs were for 16 bit and 16 kHz. I think our topologies should allow the build time parameters for the format so our testing tasks could be easier.

@plbossart
Copy link
Member

plbossart commented Mar 4, 2024

Not following his one either, are we trying to enable 16-bit DMIC for production topologies or just internal tests with development topologies?

This is needed for test with a new platform.

A new SOC or a new customer platform? I just don't get why we care about 16 bits these days.

@singalsu
Copy link
Collaborator Author

singalsu commented Mar 6, 2024

A new SOC or a new customer platform? I just don't get why we care about 16 bits these days.

New SOC still with FPGA, so we have only 19.2 MHz clock to use. We have just passed tests with 16 bit, so I will update this PR with 32 bit formats add so we can test them too. It's a stretch but it does not hurt to shift left activities.

singalsu added 8 commits March 6, 2024 17:16
The needed defaults for DMIC1 for PCM ID and sample rate are added
similarly as for DMIC0 for later use. DMIC1 related pipelines are
not used by default so DMIC1_ENABLE is set to false.

Signed-off-by: Seppo Ingalsuo <[email protected]>
The added DMIC0_RATE allows to use the DAI, pipelines, and PCM with
any supported rate for DMIC in range 8 - 96 kHz. E.g. configure
DMIC0 to 96 kHz.

There is no change to existing functionality with default 48 kHz rate.

Signed-off-by: Seppo Ingalsuo <[email protected]>
This patch optionally includes dmic1-passthrough.conf if
DMIC1_ENABLE is set in topologies build to passthrough.

The sample rate of DMIC1 DAI can be set to 8 - 96 kHz with
macro DMIC1_RATE.

Signed-off-by: Seppo Ingalsuo <[email protected]>
The macro allows to select the word length of DAI and in
pass-through pipelines the word length in the entire
pipelines.

Signed-off-by: Seppo Ingalsuo <[email protected]>
The microphone min and max bus clock rates can be customized from
build when the macros are used. The minimum rate is increased
from 500 kHz to 1.2 MHz to be sure it works for all microphones. The
Rate can be dropped in topologies build per topology back to 500 kHz
with DMIC_CLK_MIN=500000.

Signed-off-by: Seppo Ingalsuo <[email protected]>
TODO: Quick and dirty. This might cause issues if host copier
and PCM formats are not the same.

Signed-off-by: Seppo Ingalsuo <[email protected]>
This patch adds build of development topologies:
- sof-hda-generic-lnl-4ch-16k-16k-16bit.tplg
- sof-hda-generic-lnl-4ch-48k-16k-16bit.tplg
- sof-hda-generic-lnl-4ch-48k-16k-32bit.tplg
- sof-hda-generic-lnl-fpga-4ch-16k-16k-16bit.tplg
- sof-hda-generic-lnl-fpga-4ch-48k-16k-16bit.tplg
- sof-hda-generic-lnl-fpga-4ch-48k-16k-32bit.tplg

Signed-off-by: Seppo Ingalsuo <[email protected]>
The new lnl.conf is copy of mtl.conf but DMIC_DRIVER_VERSION needs
to be increased by one for a small registers change.

Signed-off-by: Seppo Ingalsuo <[email protected]>
@singalsu singalsu force-pushed the lnl_with_16bit_dmic branch from a254e16 to 40a5240 Compare March 6, 2024 15:17
@singalsu singalsu closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants