Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual memory heaps fixes #8849

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Conversation

dabekjakub
Copy link
Member

Fix various cases of allocation errors.

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dabekjakub ping - good to merge ?

@dabekjakub
Copy link
Member Author

dabekjakub commented Feb 19, 2024

The last fix coming tomorrow with the updated tests for vmh in
#8775
will switch to normal pr then and ping You both - fix will be very small - testing it now so there won't be much to re-review.

When using non contiguous allocation block size is calculated after
the check.

Signed-off-by: Jakub Dabek <[email protected]>
When allocating non contiguously if exact block size was allocated on
given physical allocator it would fail. Fix logic to include
that event.

Signed-off-by: Jakub Dabek <[email protected]>
Array holding sizes of allocations was not updated correctly this
fixes array update issue.

Signed-off-by: Jakub Dabek <[email protected]>
Allocation sizes were calculated with faulty logic. Bits to check
size calculation is not needed since array position was calculated
and loop should go from this position to array end.

Signed-off-by: Jakub Dabek <[email protected]>
@dabekjakub dabekjakub marked this pull request as ready for review February 23, 2024 15:27
@dabekjakub
Copy link
Member Author

@lgirdwood @lyakh Review/merge ready.

@mwasko mwasko merged commit 520ef18 into thesofproject:main Feb 29, 2024
39 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants