-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual memory heaps fixes #8849
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabekjakub
force-pushed
the
jdabek_vmh_fixes
branch
from
February 9, 2024 15:50
fdc8b2e
to
de1bcdc
Compare
lyakh
approved these changes
Feb 12, 2024
lgirdwood
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dabekjakub ping - good to merge ?
The last fix coming tomorrow with the updated tests for vmh in |
dabekjakub
force-pushed
the
jdabek_vmh_fixes
branch
from
February 23, 2024 15:10
de1bcdc
to
113e55f
Compare
When using non contiguous allocation block size is calculated after the check. Signed-off-by: Jakub Dabek <[email protected]>
When allocating non contiguously if exact block size was allocated on given physical allocator it would fail. Fix logic to include that event. Signed-off-by: Jakub Dabek <[email protected]>
Array holding sizes of allocations was not updated correctly this fixes array update issue. Signed-off-by: Jakub Dabek <[email protected]>
Allocation sizes were calculated with faulty logic. Bits to check size calculation is not needed since array position was calculated and loop should go from this position to array end. Signed-off-by: Jakub Dabek <[email protected]>
dabekjakub
force-pushed
the
jdabek_vmh_fixes
branch
from
February 23, 2024 15:21
113e55f
to
ea65d21
Compare
@lgirdwood @lyakh Review/merge ready. |
lgirdwood
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix various cases of allocation errors.