app/prj.conf: stop disassembling by default - 2x faster build #8825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-hb
force-pushed
the
no-default-disa
branch
from
ea3cdc6 to
cb0d2c8
Compare
Force -DCONFIG_OUTPUT_DISASSEMBLY=y when building Zephyr to make sure the disassembly is compared between the Windows and Linux builds. Signed-off-by: Marc Herbert <[email protected]>
This reverts 8f60180 ("app: enable OUTPUT_DISASSEMBLY for Zephyr builds") The disassembly is useful in some contexts but can't be parallelized and takes an enormous amount of time. On my system OUTPUT_DISASSEMBLY almost doubles the compilation time! Quoting Zephyr commit cc5763344709: > This on-by-default option takes the majority of "link" time. If people > need the disassembly, they can turn it on. Signed-off-by: Marc Herbert <[email protected]>
marc-hb
force-pushed
the
no-default-disa
branch
from
cb0d2c8 to
50e4bd8
Compare
marc-hb
changed the title
marc-hb
requested review from
dbaluta,
cujomalainey,
lgirdwood,
plbossart,
mmaka1,
lbetlej and
kv2019i
as code owners
marc-hb
requested review from
keqiaozhang,
aiChaoSONG,
iuliana-prodan,
wszypelt,
softwarecki and
lrudyX
|
1 suspend/resume failure in https://sof-ci.01.org/sofpr/PR8825/build2506/devicetest/index.html ACE https://sof-ci.01.org/sofpr/PR8825/build2505/devicetest/index.html all green https://sof-ci.01.org/sofpr/PR8825/build2504/build all green. |
softwarecki
approved these changes
Feb 1, 2024
kv2019i
approved these changes
Feb 1, 2024
iuliana-prodan
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... keep disassembling in github actions.
2 commits, see commit messages.