topology2: Add topology for testing SOF plugin #8815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The topology uses passthrough pipelines for playback/capture and supports only 48k, 2ch, 16bit format for now. Signed-off-by: Ranjani Sridharan <[email protected]>
ranj063
requested review from
jsarha,
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
plbossart
reviewed
Jan 30, 2024
| @@ -66,9 +66,9 @@ The above example needs to be 48k as example pipe has no SRC/ASRC. | |||
| Likewise | |||
|
|
|||
| ``` | |||
| arecord -Dsof:tgl-nocodec:1:default:default:48k2c16b -f dat file.wav | |||
| arecord -Dsof:plugin:1:default:default:48k2c16b -f dat file.wav | |||
There was a problem hiding this comment.
it:would:not:hurt:to:document:all:these:options:never:seen:this:before
There was a problem hiding this comment.
@plbossart it is documented in the plugin usage help message and in the same README file below
|
|
||
| Object.Widget.dai-copier."1" { | ||
| dai_index 1 | ||
| dai_type "SSP" |
There was a problem hiding this comment.
does the concept of SSP make any sense for a plugin at the ALSA-lib level? Why is this needed?
There was a problem hiding this comment.
it is not really needed for the plugin but these are mandatory attributes for a dai-copier and I cant create one without it. I will have to update the host/dai copier to remove these but for now, we have no choice
lgirdwood
reviewed
Jan 31, 2024
kv2019i
approved these changes
Feb 1, 2024
singalsu
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The topology uses passthrough pipelines for playback/capture and supports only 48k, 2ch, 16bit format for now.