DO NOT MERGE! JUST FOR CI RUN. #8576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mute channel functionality was previously used as part of channel remapping feature. Since that feature was removed some time ago mute channel functionality is no longer used and is just a leftover from not fully completed cleanup. Signed-off-by: Serhiy Katsyuba <[email protected]>
Previously we had "normal" and "channel remapping" modes. Since channel remapping mode was removed, "normal" is the only supported mode, no need to prepend names with "normal". Signed-off-by: Serhiy Katsyuba <[email protected]>
Previously when channel remapping was supported processing was done iterating by frames. After channel remapping was removed processing was changed to iterate by samples, however, for some reason the code still uses confusing "frame" variables. Signed-off-by: Serhiy Katsyuba <[email protected]>
Modifications to mixin/mixout .process() and .reset() implementations to switch to use sink/source API. Signed-off-by: Serhiy Katsyuba <[email protected]>
In channel remapping mode mixin sinks could have different number of channels. Since channel remapping mode has been removed, no need to support individual channel number setup for each sink. Signed-off-by: Serhiy Katsyuba <[email protected]>
The removed code may falsely fail for freq like 44.1 kHz. Also, we generally do not check for sufficient buffer size in module .prepare() handler. That should be/is done elsewhere. No need to do the exception for mixout component. Signed-off-by: Serhiy Katsyuba <[email protected]>
Modification of mixin/mixout .prepare() handler to use sink/source API. Signed-off-by: Serhiy Katsyuba <[email protected]>
This was referenced Dec 6, 2023
serhiy-katsyuba-intel
force-pushed
the
mixer_ssapi_test
branch
from
a29beba to
30cf144
Compare
Module will update source & sink information when bind & unbind event happen. Signed-off-by: Rander Wang <[email protected]>
…ction It is done in bind function. Signed-off-by: Marcin Szkudlinski <[email protected]>
serhiy-katsyuba-intel
force-pushed
the
mixer_ssapi_test
branch
from
30cf144 to
35ca9e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR just to run the CI. DO NOT MERGE!