topology2:cavs-es83x6: Add support to Es8326 codec + HDMI-in capture #8518
Conversation
CBala21
force-pushed
the
mtl-Es8326+HDMI-in
branch
2 times, most recently
from
e4876db to
39d596c
Compare
| copier_type "SSP" | ||
| stream_name "$HEADSET_CODEC_NAME" | ||
| node_type $I2S_LINK_INPUT_CLASS | ||
| Object.Base.audio_format.1 { |
There was a problem hiding this comment.
Please use Object.Base.input_audio_format and Object.Base.output_audio_format
There was a problem hiding this comment.
Updated, please check the latest
| io-gateway-capture [ | ||
| { | ||
| index 6 | ||
| direction capture |
There was a problem hiding this comment.
direction capture is not needed for io-gateway-capture
There was a problem hiding this comment.
Corrected. please check the latest.
CBala21
force-pushed
the
mtl-Es8326+HDMI-in
branch
2 times, most recently
from
21eea25 to
5b7dc0f
Compare
| # include deep buffer config if buffer size is in 1 - 1000 ms. | ||
| IncludeByKey.DEEPBUFFER_FW_DMA_MS{ | ||
| "([1-9]|[1-9][0-9]|[1-9][0-9][0-9]|1000)" "platform/intel/deep-buffer.conf" | ||
| } |
There was a problem hiding this comment.
Really we are not using in our platform but try to make as similar topology(RT5682) and in future people can use it for other platforms. please let me know if you feel its unnecessary and wants to remove it.
There was a problem hiding this comment.
Please check my above comments and do suggest. Thanks.
There was a problem hiding this comment.
@plbossart @ranj063 can you check? I guess the intention is not to drift too far from the rt5682 tplg used as reference for this
There was a problem hiding this comment.
well, so if the intent is to track an existing topology then adding a new one is really not the direction. There's no such thing as a reference and 'not drift too far', as soon as you fork a new topology it will bit-rot and diverge.
You'd want to use the same setup really and add the HDMI input that is probably the only thing missing?
There was a problem hiding this comment.
@plbossart : As you suggested, i have removed the unused feature and uploaded the latest. please review and help to get it merge.
Add Es8326 codec support and HDMI-in capture via I2S. Signed-off-by: Balamurugan C <[email protected]>
CBala21
force-pushed
the
mtl-Es8326+HDMI-in
branch
from
5b7dc0f to
d113ea7
Compare
|
FYI @marc-hb @ranj063 hmm, user-space plugin build failing on unrelated PR -> https://github.com/thesofproject/sof/actions/runs/7084022031/job/19277476250?pr=8518 ... potentially conflict in PRs merged end of last week that is triggering this. |
|
Please continue the review on #8570 |
|
Created the new PR #8570 top on latest commits. Hence closing this PR. |
Add Es8326 codec support and HDMI-in capture via I2S.