module_adapter : dts: update the paths of DTS related codes and library #8516
Conversation
Update the path to import DTS library from third_party/lib/ instead of src/audio/module_adapter/lib/release/. This action was requested in PR#8379. Signed-off-by: Joe Cheng <[email protected]>
joechengxperi
requested review from
marc-hb,
ranj063,
jxstelter,
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
joechengxperi
requested review from
cujomalainey,
btian1,
johnylin76,
markbartonxperi and
macchian
src/audio/Kconfig
Outdated
| For more information, please contact [email protected] | ||
|
|
||
| config DTS_CODEC_STUB | ||
| bool "DTS codec stub" |
There was a problem hiding this comment.
why does this option have to be user-selectable? The above DTS_CODEC will select this one if COMP_STUBS is enabled, and this option depends on DTS_CODEC anyway. And I assume it cannot be selected without COMP_STUBS either? (should it depend on it too?) So, this option - if at all needed - can be hidden?
There was a problem hiding this comment.
This would require @cujomalainey comment.
And for this question,
"And I assume it cannot be selected without COMP_STUBS either?" The answer is yes. DTS_CODEC_STUB requires both DTS_CODEC and COMP_STUBS enabled.
There was a problem hiding this comment.
I think we need this Kconfig if we are building any different DTS code, or stubs for any other module. i.e. the user has to actively select the module and also say I want to build the module as a stub. Otherwise its easy to select DTS and have KCONFIG_STUBs enabled elsewhere in Kconfig and then waste time debugging module build/init (where's my module?).
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| #include <rtos/init.h> | |||
| #include <sof/audio/module_adapter/module/generic.h> | |||
| #include <sof/audio/dts/DtsSofInterface.h> | |||
| #include <DtsSofInterface.h> | |||
Update the path to include DTS header files from third_party/include/. This action was requested in PR#8379. Signed-off-by: Joe Cheng <[email protected]>
joechengxperi
force-pushed
the
update-dts-path
branch
from
a3b639a to
46df996
Compare
This was suggested in PR#8389. Since the module uses module_interface, it doesn't have to put it under module_adaper/module/. Move dts codes from src/audo/module_adapter/module/ to src/audio/codec. Signed-off-by: Joe Cheng <[email protected]>
joechengxperi
force-pushed
the
update-dts-path
branch
from
46df996 to
6db27d7
Compare
This is a follow-up of PR#8379 to implement the below three items related to code relocation.