tools/topology1: mass replace codec_master -> codec_provider #8442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/thesofproject/sof/actions/runs/6750662401/job/18353468993?pr=8442 is unrelated, fixed by #8441 |
marc-hb
requested review from
dbaluta,
plbossart,
fredoh9,
iuliana-prodan,
maruthi-machani,
saisurya-ch,
a team,
johnylin76,
Vamshigopal,
CBala21 and
yongzhi1
ranj063
approved these changes
Nov 6, 2023
This removes a lot of warning noise and may help spot other warnings like `ALSA lib ops.c:48:(lookup_ops) wrong kcontrol ops value string ''` and others. Now that commit 1b1ec6c ("topology/cmake: skip all topologies when alsatplg < 1.2.5") enforces alsatplg version >= 1.2.5, it is finally safe to do this! I compared the generated .tplg files before/after this commit and they're bit for bit identical. Tested with both alsatplg v2.6.1 from Ubuntu 22 and version 1.2.9 from the SOF docker container. Note this is a much smaller commit than the reverted commit f50b6fe ("topologies: switch all .m4 files to codec_provider and codec_consumer") because most topologies v1 have been removed from the main branch. Most topologies v1 are now only in stable-v2.2 where the warning spam is still a problem :-( Signed-off-by: Marc Herbert <[email protected]>
This removes a lot of warning noise and may help spot other warnings like `ALSA lib ops.c:48:(lookup_ops) wrong kcontrol ops value string ''` and others. Now that commit 1b1ec6c ("topology/cmake: skip all topologies when alsatplg < 1.2.5") enforces alsatplg version >= 1.2.5, it is finally safe to do this! I compared the generated .tplg files before/after this commit and they're bit for bit identical. Tested with alsatplg v2.6.1 from Ubuntu 22. Signed-off-by: Marc Herbert <[email protected]>
marc-hb
force-pushed
the
codec-master-provider
branch
from
3d71a9f to
3fbf39a
Compare
marc-hb
requested review from
lgirdwood,
mmaka1,
lbetlej and
kv2019i
as code owners
|
v2:
|
CBala21
approved these changes
Nov 9, 2023
kv2019i
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a lot of warning noise and may help spot other warnings like
ALSA lib ops.c:48:(lookup_ops) wrong kcontrol ops value string ''and others.Now that commit 1b1ec6c ("topology/cmake: skip all topologies when alsatplg < 1.2.5") enforces alsatplg version >= 1.2.5, it is finally safe to do this!
I compared the generated .tplg files before/after this commit and they're bit for bit identical. Tested with both alsatplg v2.6.1 from Ubuntu 22 and version 1.2.9 from the SOF docker container.
Note this is a much smaller commit than the reverted commit f50b6fe ("topologies: switch all .m4 files to codec_provider and codec_consumer") because most topologies v1 have been removed from the main branch. Most topologies v1 are now only in stable-v2.2 where the warning spam is still a problem :-(