ASoC: Intel: sof_ssp_amp: remove dead code #4694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentlu
requested review from
lgirdwood,
plbossart,
ranj063,
kv2019i,
dbaluta,
bardliao,
ujfalusi,
vijendarmukunda,
kuanhsuncheng and
yaochunhung
as code owners
bardliao
previously approved these changes
Nov 9, 2023
CBala21
reviewed
Nov 9, 2023
sound/soc/intel/boards/sof_ssp_amp.c
Outdated
| /* this board is using fixed number for each BE ID */ | ||
| fixed_be = true; | ||
| } | ||
|
|
||
| /* HDMI-In SSP */ | ||
| if (sof_ssp_amp_quirk & SOF_SSP_HDMI_CAPTURE_PRESENT) { |
There was a problem hiding this comment.
Already Based on this condition fixed_be flag has been set and by default it should be false for other platforms. why we need again use one quirk flag to set it. anyhow all HDMI-in capture supported platform uses fixed be because we don't want to change topology and driver for every platform and trying to keep common. Please check and comment.
There was a problem hiding this comment.
It's only for code readability and no functional change here. Do you think it's overdesign?
brentlu
force-pushed
the
dead-code-fix
branch
from
df6ba70 to
6f5d5ca
Compare
|
upload a new version which only removes dead code |
brentlu
changed the title
plbossart
requested changes
Nov 9, 2023
brentlu
force-pushed
the
dead-code-fix
branch
from
6f5d5ca to
cc216b0
Compare
CBala21
approved these changes
Nov 9, 2023
plbossart
approved these changes
Nov 9, 2023
This patch fixes a dead code problem when calculating BE ID for each HDMI-In link. Signed-off-by: Brent Lu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve code readability, we add a quirk SOF_TOPOLOGY_FIXED_BE_ID for boards which use sof-tgl-rt1308-hdmi-ssp.m4 topology. In the topology, the ID for each BE link is a fixed number.
This also fixes a dead code problem when calulating BE ID for each HDMI-In link.