Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more similarity measurements, fixes #124 #188

Closed
wants to merge 7 commits into from

Conversation

FanwangM
Copy link
Collaborator

@FanwangM FanwangM commented Dec 1, 2023

This PR addresses #124. The SimilarityIndex class was moved to similarity module to make things consistent, which is mainly for calculating similarity matrix. The smilarity.py in method module was renamed to sim.py because we have two similarity.py files, which can be very confusing. Actually I would perfer to use nsim.py, but to keep things consistent with other files name, I chose sim.py.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: Patch coverage is 97.62846% with 6 lines in your changes missing coverage. Please review.

Project coverage is 96.96%. Comparing base (0de2c9b) to head (d5cc58d).
Report is 37 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   97.57%   96.96%   -0.61%     
==========================================
  Files           9        9              
  Lines         907      924      +17     
==========================================
+ Hits          885      896      +11     
- Misses         22       28       +6     
Files Coverage Δ
selector/methods/__init__.py 100.00% <100.00%> (ø)
selector/methods/sim.py 96.05% <96.05%> (ø)
selector/similarity.py 98.61% <98.29%> (-1.39%) ⬇️

... and 1 file with indirect coverage changes

@FanwangM FanwangM changed the title Add more similarity measurements, fixes 124 Add more similarity measurements, fixes #124 Dec 1, 2023
@FanwangM FanwangM self-assigned this Jun 25, 2024
@FanwangM
Copy link
Collaborator Author

I am going to close this PR as this has been addressed by

@FanwangM FanwangM closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants