Cleanup of Directed Spheres class #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `test_gridpartitioning` is commented, because the GridPartitioning is not comptable with the new API.
FarnazH
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
@AWBroscius, please review the changes I made to the code, and let me know if you have any questions or suggestions.
@FanwangM, I am done with making changes to this PR, so it can be merged. I have made a list of items that should be discussed in our next meeting; see #133 (comment)
Codecov Report
@@ Coverage Diff @@
## main #142 +/- ##
==========================================
+ Coverage 39.53% 40.54% +1.00%
==========================================
Files 8 8
Lines 564 555 -9
==========================================
+ Hits 223 225 +2
+ Misses 341 330 -11
|
JackyZzZz
pushed a commit
to JackyZzZz/Selector
that referenced
this pull request
Jun 14, 2024
Cleanup of Directed Spheres class
FanwangM
added a commit
that referenced
this pull request
Jul 2, 2024
Cleanup of Directed Spheres class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize the Directed Sphere exclusion code, as well as add comments and testing to address issue #133