modelValue set to be optional in FwbInput

[andreyjamer]

Starting version 0.1.7 there is a problem with FwbInput component

Seems like it is caused by this PR #327
If modelValue has 2 possible types, then is it not optional anymore. It should be marked as optional explicitly in the type definition. I checked modelValue definitions in other components and all of them are optional.

Strange thing that I cannot reproduce this issue on the flowbite-vue code base. Only in the project.

Summary by CodeRabbit

• Improvements
  • Enhanced input component flexibility by making modelValue an optional property
  • Added default empty string for modelValue when not explicitly provided

[coderabbitai]

Walkthrough

The pull request modifies the FwbInput.vue component by changing the modelValue property in the InputProps interface from a required to an optional property. This adjustment allows the modelValue to be omitted when using the component. The withDefaults function is updated to set a default empty string value for modelValue, ensuring consistent behavior when the prop is not explicitly provided.

Changes

File	Change Summary
src/components/FwbInput/FwbInput.vue	- modelValue property made optional in InputProps interface - Default value set to empty string using withDefaults

Possibly related PRs

• Fix FWBInput does not support v-model.number (#273) #327: Modifies the modelValue property in the InputProps interface of FwbInput.vue

Suggested reviewers

• Sqrcz

Poem

🐰 A Vue component's gentle dance,
Optional values now enhance!
modelValue free to roam,
No longer bound, it finds its home
In empty strings, a soft embrace 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for sensational-seahorse-8635f8 ready!

Name	Link
🔨 Latest commit	f1c91c5
🔍 Latest deploy log	https://app.netlify.com/sites/sensational-seahorse-8635f8/deploys/67937e56a3f8010008139438
😎 Deploy Preview	https://deploy-preview-343--sensational-seahorse-8635f8.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/components/FwbInput/FwbInput.vue (1)

64-64: Making modelValue optional aligns with other components.
This change ensures flexibility by allowing the prop to be omitted if needed. However, consider confirming whether an empty string is the most appropriate default when a numeric modelValue may be expected.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8f6968b and f1c91c5.

📒 Files selected for processing (1)

• src/components/FwbInput/FwbInput.vue (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build-pkg (20.x)

[Sqrcz]

Thank you for the PR... I'll test it in the evening in my project and return to you with proper response.

[Sqrcz]

Hey,

Sorry I've drowned in changes for this PR: #344 and wasn't able to take a look at this issue yet.... I'll be back on it before the end of the weekend though ;)