Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed sizes for toggle components #295

Closed
wants to merge 1 commit into from

Conversation

andreyjamer
Copy link
Contributor

@andreyjamer andreyjamer commented Jun 27, 2024

Toggle component has problems with sizes. Especially the sm size:
image

Here is a fix with proper Tailwind classes

Summary by CodeRabbit

  • New Features

    • Improved support for right-to-left (RTL) layouts in the toggle component, enhancing accessibility for users in different language contexts.
  • Improvements

    • Updated CSS class definitions to align with modern practices, ensuring better responsiveness and compatibility with RTL layouts.

Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for sensational-seahorse-8635f8 ready!

Name Link
🔨 Latest commit 1851aee
🔍 Latest deploy log https://app.netlify.com/sites/sensational-seahorse-8635f8/deploys/667d7191bec2a70008edfff1
😎 Deploy Preview https://deploy-preview-295--sensational-seahorse-8635f8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andreyjamer andreyjamer changed the title Fixed sizes for toggle components fix: Fixed sizes for toggle components Jun 27, 2024
Copy link
Collaborator

@Sqrcz Sqrcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nica catch... and solid fix.

Thank you.

@Sqrcz
Copy link
Collaborator

Sqrcz commented Aug 3, 2024

Hey @andreyjamer 👋

Can you please fix conflict... it clashes with your other PR ;)

@Sqrcz Sqrcz self-assigned this Aug 6, 2024
@Sqrcz Sqrcz added the 🪲 bug Something isn't working label Aug 6, 2024
Copy link
Contributor

coderabbitai bot commented Aug 6, 2024

Walkthrough

The recent changes enhance the toggle component's adaptability for different layouts, particularly for right-to-left (RTL) languages. Key improvements include the introduction of RTL support in CSS class definitions and adjustments to align properties with modern practices. These modifications ensure the toggle is more accessible and user-friendly across various language contexts, improving overall responsiveness and usability.

Changes

Files Change Summary
src/components/FwbToggle/composables/useToggleClasses.ts Added rtl: prefix to CSS classes for RTL support; replaced left with start in size variants to enhance responsiveness.

Poem

🐰 In a world where toggles sway,
RTL dances in bright array.
Classes shift, and all is right,
Usability takes flight,
With each flick, we cheer and play,
A joyful leap in CSS ballet! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a0f04ed and 1851aee.

Files selected for processing (1)
  • src/components/FwbToggle/composables/useToggleClasses.ts (1 hunks)
Additional comments not posted (2)
src/components/FwbToggle/composables/useToggleClasses.ts (2)

6-6: LGTM! RTL support added correctly.

The addition of the rtl: prefix to the peer-checked:after:-translate-x-full class enhances the component's accessibility and usability in RTL layouts.


9-11: LGTM! Modern CSS practices applied.

The change from left to start in the toggleSizeClasses object aligns with modern CSS practices and ensures better compatibility with RTL layouts.

@Sqrcz
Copy link
Collaborator

Sqrcz commented Aug 6, 2024

Ok, I'm closing this one... as this changes are already merged with this PR

@Sqrcz Sqrcz closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants