-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixed sizes for toggle components #295
Conversation
✅ Deploy Preview for sensational-seahorse-8635f8 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nica catch... and solid fix.
Thank you.
Hey @andreyjamer 👋 Can you please fix conflict... it clashes with your other PR ;) |
WalkthroughThe recent changes enhance the toggle component's adaptability for different layouts, particularly for right-to-left (RTL) languages. Key improvements include the introduction of RTL support in CSS class definitions and adjustments to align properties with modern practices. These modifications ensure the toggle is more accessible and user-friendly across various language contexts, improving overall responsiveness and usability. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/components/FwbToggle/composables/useToggleClasses.ts (1 hunks)
Additional comments not posted (2)
src/components/FwbToggle/composables/useToggleClasses.ts (2)
6-6
: LGTM! RTL support added correctly.The addition of the
rtl:
prefix to thepeer-checked:after:-translate-x-full
class enhances the component's accessibility and usability in RTL layouts.
9-11
: LGTM! Modern CSS practices applied.The change from
left
tostart
in thetoggleSizeClasses
object aligns with modern CSS practices and ensures better compatibility with RTL layouts.
Ok, I'm closing this one... as this changes are already merged with this PR |
Toggle component has problems with sizes. Especially the
sm
size:Here is a fix with proper Tailwind classes
Summary by CodeRabbit
New Features
Improvements