Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More supports of MathJax3 #1378

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

Liam0205
Copy link
Contributor

@Liam0205 Liam0205 commented Feb 12, 2020

PR Checklist

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

Related issues/pull requests: #1314

#1314 introduced support of MathJax3, which should be shown appreciation to. This PR

  • loads the amsmath package, who is the standard-in-reality of math-typesetting in LaTeX-world, by default;
  • translates `$ ... $`, `\( ... \)`, `$$ ... $$`, and `\begin{foo} ... \end{bar}` into specific span, and waiting for MathJax's processing, when theme.math.mathjax.codemath is set to be true.

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

N/A

Does this PR introduce a breaking change?

  • Yes.
  • No.

@Liam0205 Liam0205 changed the title More supports of MathJax3 WIP: More supports of MathJax3 Feb 12, 2020
@Liam0205 Liam0205 changed the title WIP: More supports of MathJax3 More supports of MathJax3 Feb 12, 2020
Copy link
Contributor

@stevenjoezhang stevenjoezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can write the implementation of this feature as a blog post and provide a link here:
https://github.com/next-theme/awesome-next#tutorial

I'm not sure how many users need this feature. Maybe you can start a poll to investigate? I am worried that writing mathematical formulas in code blocks is just a workaround, not a general solution. This can be misleading for new users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants