explicitly migrate the test DB #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Sep 11, 2024
| @@ -20,7 +20,7 @@ def configureDatabase(ruby) { | |||
| bundleExec(ruby, 'rake db:drop >/dev/null 2>/dev/null || true') | |||
| bundleExec(ruby, 'rake db:create --trace') | |||
| bundleExec(ruby, 'rake db:create --trace RAILS_ENV=production') | |||
| bundleExec(ruby, 'rake db:migrate --trace') | |||
There was a problem hiding this comment.
I'd like consistency with the db:create statements.
There was a problem hiding this comment.
and by consistency you mean "delete the creates, they are implicit by migrate"? :)
There was a problem hiding this comment.
mhh, we still need create for prod (which is not migrated, but needs to exist for asset compilation, and we probably do not properly set DATABASE_URL=nulldb://nohost everywhere)
There was a problem hiding this comment.
so I updated the create to have RAILS_ENV=test, that should be safe, we can get things rolling (again) and do the cleanup later.
evgeni
force-pushed
the
explicit-migrate-test
branch
from
5dfc101
to
9ee18f4
Compare
ekohl
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.