Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ruby version check in plugin test #399

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

adamruzicka
Copy link
Contributor

Before

$ if ["${ruby}" = '2.7']; then echo yay; fi
bash: [2.7: command not found

After

$ if [ "${ruby}" = '2.7' ]; then echo yay; fi
yay

Fixes: f164a3f

@adamruzicka
Copy link
Contributor Author

Hopefully should address this kind of failure https://ci.theforeman.org/job/foreman_openscap-pull-request/531/label=fast,ruby=2.7/console

Before
$ if ["${ruby}" = '2.7']; then echo yay; fi
bash: [2.7: command not found

After
$ if [ "${ruby}" = '2.7' ]; then echo yay; fi
yay

Fixes: f164a3f
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was debating this when I reviewed it. @pcreech guess I should have commented after all ;)

@ekohl ekohl merged commit a68120f into theforeman:master Jan 5, 2024
2 checks passed
@adamruzicka adamruzicka deleted the fix-plugin-bundler branch January 5, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants