Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Copr nightly test pipeline #349

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Aug 15, 2023

No description provided.

@ehelms
Copy link
Member Author

ehelms commented Aug 30, 2023

I am using these as a playground, we do not necessarily need independent jobs in the end. I've expressed this here the options as I see them:

theforeman/forklift#1700 (comment)

@ehelms
Copy link
Member Author

ehelms commented Aug 30, 2023

This will be adapted based upon the approach settled with the client -- #351

@ehelms ehelms force-pushed the copr-add-nightly-test-pipeline branch 2 times, most recently from 1d26169 to 855d4a2 Compare October 29, 2023 13:35
@ehelms ehelms marked this pull request as ready for review October 29, 2023 13:36
@ehelms ehelms force-pushed the copr-add-nightly-test-pipeline branch 4 times, most recently from bf4eee7 to 89de1a4 Compare October 30, 2023 17:44
@ehelms ehelms force-pushed the copr-add-nightly-test-pipeline branch from 89de1a4 to 9d939a6 Compare October 30, 2023 17:56
@ehelms ehelms requested a review from evgeni October 30, 2023 20:05
@ehelms
Copy link
Member Author

ehelms commented Oct 30, 2023

Proposed order of operations:

  1. Merge this change tat keeps the regular Koji pipeline running but adds the switch to stagingyum
  2. Swap to stagingyum in our CI job (Switch to stagingyum #365)
  3. Swap to stagingyum in Forklift pipelines (Enable stagingyum repositories for nightly pipelines forklift#1717)


steps {
script {
runDuffyPipeline('foreman-rpm', foreman_version)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should/could this pass staging_source somehow, so we don't need theforeman/forklift#1717?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mhh, runDuffyPipeline doesn't allow us to pass arbitrary parameters to the job, so probably not so easy.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reached the same conclusion. However, forklift should match CI if someone goes to run things so I think it's OK.

@ehelms ehelms merged commit 5de6898 into theforeman:master Oct 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants