Drop smart_proxy_dynflow PR test #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only thing I can think of is the weekly test we now run, but I'm not sure that adds any real value right now. https://ci.theforeman.org/job/smart-proxy-dynflow-test/ |
|
I'm not convinced it does either, and it has low visibility. We could opt to run the Github Actions on a schedule if we wanted to achieve this same idea. |
ehelms
force-pushed
the
drop-dynflow-pr-test
branch
from
2da9801
to
f892d41
Compare
|
Added a drop for the weekly test |
|
@ekohl give this another look? |
ekohl
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reviewing theforeman/smart_proxy_dynflow#123 and noticed at this point the smart_proxy_dynflow repository runs the same set of tests in Github Actions and Jenkins. I feel we can drop this duplication in Jenkins.