Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Foreman < 3.8 versions support #1844

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

archanaserver
Copy link
Contributor

@archanaserver archanaserver commented Aug 20, 2024

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this current PR should be summarized as "Update forklift_versions role tests to use current versions" or similar.

But taking a step back, I'd combine this with another change: drop older boxes. We have versions.yaml and we can drop older versions there.

What we at least need to keep is currently supported versions (3.10, 3.11 & nightly) and what's needed to release them. To release 3.10, we need n-2 so 3.8. That means you can drop 3.7 and older.

To do that, you need to update the tests, but that's usually not the objective. So the PR summary should then be something like "Drop Foreman < 3.8 versions".

When dropping older version support, you can take a look if there are some version specific hacks that can also be dropped, but there is some downstream concern. Forklift is also used in Satellite so you may need to keep 3.5 support for now.

You can consider dropping the versions 1 by 1, each in a separate commit. Start with the oldest and work your way to the newest.

@archanaserver
Copy link
Contributor Author

When dropping older version support, you can take a look if there are some version specific hacks that can also be dropped, but there is some downstream concern. Forklift is also used in Satellite so you may need to keep 3.5 support for now.

@ekohl I've been using this file to check the versions compatibility but how can I review the dependency for candlepin, pulpcore and puppet for the selected foreman and katello version?

@archanaserver archanaserver force-pushed the os-version-update branch 2 times, most recently from 3418ffc to 9a9a180 Compare August 30, 2024 17:25
@archanaserver archanaserver marked this pull request as draft August 30, 2024 17:25
@archanaserver archanaserver changed the title Ansible update to cover new OS version Update forklift_versions role tests to use current versions Aug 30, 2024
@archanaserver archanaserver force-pushed the os-version-update branch 2 times, most recently from 400dc9d to 6c02adc Compare August 30, 2024 17:36
@archanaserver archanaserver force-pushed the os-version-update branch 3 times, most recently from 0c437ab to 1161d1f Compare September 3, 2024 07:55
@archanaserver archanaserver force-pushed the os-version-update branch 5 times, most recently from d0bdd41 to 2a3cba2 Compare September 4, 2024 06:07
@archanaserver archanaserver marked this pull request as ready for review September 4, 2024 06:07
@archanaserver archanaserver changed the title Update forklift_versions role tests to use current versions Drop Foreman < 3.8 versions support Sep 4, 2024
@archanaserver archanaserver force-pushed the os-version-update branch 4 times, most recently from 2edff7d to 1b93f6c Compare September 4, 2024 08:35
vagrant/config/versions.yaml Outdated Show resolved Hide resolved
@evgeni evgeni merged commit 1ebf690 into theforeman:master Sep 4, 2024
8 checks passed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was dropping centos 7 & 8 intended to be part of this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it's fine as a cleanup? :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have preferred it to be more explicit and at least as a separate commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants