Add backup tests for foreman-proxy #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Aug 17, 2024
jameerpathan111
suggested changes
Aug 19, 2024
bats/fb-test-backup.bats
Outdated
|
|
||
| tFileExists "${BACKUP_ONLINE_DIR}/pulp_data.tar" | ||
| tFileExists "${BACKUP_ONLINE_DIR}/pulpcore.dump" | ||
| tar -tvf "${BACKUP_ONLINE_DIR}/config_files.tar.gz" | grep "${HOSTNAME}.tar.gz" |
There was a problem hiding this comment.
Suggested change
| tar -tvf "${BACKUP_ONLINE_DIR}/config_files.tar.gz" | grep "${HOSTNAME}.tar.gz" | |
| tar -tvf "${BACKUP_ONLINE_DIR}/config_files.tar.gz" | grep "${HOSTNAME}-certs.tar" |
It should be like this, or at least that's how the file on my machine is.
There was a problem hiding this comment.
This depends on what you pass to the certs generate command. And our role in forklift uses: foreman_proxy_content_certs_tar: "/root/{{ ansible_nodename }}.tar.gz"
ehelms
force-pushed
the
add-backup-tests-certs-tar
branch
from
5dc2c54
to
028f304
Compare
evgeni
requested changes
Aug 19, 2024
bats/fb-test-backup.bats
Outdated
|
|
||
| if ! tPackageExists foreman && tPackageExists foreman-installer-katello; then | ||
| tFileExists "${BACKUP_OFFLINE_DIR}/pulp_data.tar" | ||
| tFileExists "${BACKUP_OFFLINE_DIR}/pgsql_data.tar.gz" |
There was a problem hiding this comment.
We don't do pgsql_data.tar.gz for offline backups anymore ;)
See lines 43++ how to check that properly based on Foreman version (well, you probably need to check installer version, there).
There was a problem hiding this comment.
Makes sense, I had tested on Katello 4.13.
ehelms
force-pushed
the
add-backup-tests-certs-tar
branch
from
028f304
to
ae7357d
Compare
evgeni
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.