Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stagingyum repositories URLs #1765

Closed

Conversation

wbclark
Copy link
Contributor

@wbclark wbclark commented Feb 12, 2024

https://stagingyum.theforeman.org/foreman/staging/el8/x86_64/ returns 404, it should be https://stagingyum.theforeman.org/foreman/nightly/el8/x86_64/

This fixes the issue for those who don't have in their box yaml: katello_repositories_version: nightly

https://stagingyum.theforeman.org/foreman/staging/el8/x86_64/ returns 404,
it should be https://stagingyum.theforeman.org/foreman/nightly/el8/x86_64/

This fixes the issue for those who don't have in their box yaml:
katello_repositories_version: nightly
Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you gotta set the right version. "Staging" is not a version.

@wbclark
Copy link
Contributor Author

wbclark commented Feb 12, 2024

No, you gotta set the right version. "Staging" is not a version.

it's not clear to me where that's coming from.

I had katello_repositories_version: nightly in my box yaml already so it just worked for me.

But that's already the default for the katello_repositories role: https://github.com/theforeman/forklift/blob/master/roles/katello_repositories/defaults/main.yml#L2

@wbclark
Copy link
Contributor Author

wbclark commented Feb 12, 2024

CC: @ianballou this looks like it should have been working for you already using the defaults -- were you passing some extra variables to your box that were breaking it?

@ianballou
Copy link
Contributor

CC: @ianballou this looks like it should have been working for you already using the defaults -- were you passing some extra variables to your box that were breaking it?

Very likely yes! However I got it to work with:

centos8-katello-devel-2:
  primary: true
  box: centos8-stream
  cpus: 2
  memory: 15000
  ansible:
    playbook: 'playbooks/katello_devel.yml'
    group: 'devel'
    variables:
      ssh_forward_agent: true
      foreman_installer_options:
        - "--foreman-proxy-content-enable-ostree=true"
      foreman_repositories_environment: staging
      katello_repositories_environment: staging
      foreman_repositories_version: nightly
      katello_repositories_version: nightly

@ianballou
Copy link
Contributor

I think we still want to be able to set the repositories version since https://stagingyum.theforeman.org/katello/ for example has both nightly and 4.11. 99% of the time we'll use nightly for katello devel, but maybe some other automation will consume the staging 4.11 rpms.

@evgeni
Copy link
Member

evgeni commented Feb 12, 2024

Every release pipeline uses those repos to validate them before pushing them live ;)

@wbclark
Copy link
Contributor Author

wbclark commented Feb 23, 2024

Closing as this was not ultimately needed.

@wbclark wbclark closed this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants