Use ansible_user_dir in customize_home role #1760

wbclark · 2024-02-08T22:23:29Z

This was only working when run under the vagrant user

roles/customize_home/tasks/main.yml

evgeni · 2024-02-13T07:06:58Z

roles/customize_home/tasks/fix_env.yml

@@ -1,11 +1,11 @@
 - name: Check that the .env exists
  stat:
-    path: /home/vagrant/foreman/.env
+    path: "/home/{{ ansible_user }}/foreman/.env"


How about

Suggested change

path: "/home/{{ ansible_user }}/foreman/.env"

path: "{{ ansible_user_dir }}/foreman/.env"

(from https://github.com/ansible/ansible/blob/stable-2.16/lib/ansible/module_utils/facts/system/user.py)

This should be present in any run that has facts enabled, but has the benefit of not guessing the home dir as /home/$USERNAME but actually looking it up from the user database.

Thanks, I'll give it a test

This only works if I manually add ansible_user_dir to the variables for the ansible provisioner in the box yaml config... otherwise (I guess because become: true in playbooks/katello_devel.yml) it still tries to use /root

I also realized that I was already overriding the value for ansible_user in my box, so that is likely the only reason my other approach was working (and I must have encountered something like this before already)

I suppose I could just add a role variable here with a default value that works for most setups to avoid this annoying behavior with become

ah, yeah… become certainly kills that.

role variable sounds good to me then!

Another idea, can we force become: false when running this role?

Another idea, can we force become: false when running this role?

See the thread above this one that I marked as "resolved" :(

but with become: false it fails due to permission denied.

Another idea, can we force become: false when running this role?

although I was using become: false for just the one task and not the whole role, and the user should have permission to modify the contents of their own home directory....

OK, the issue appears to be that we have become: true in playbooks/katello_devel.yml and specifying the become behavior at the more granular level of roles or tasks was not changing the value of variables like ansible_user_dir that get determined statically.

The good news is that it looks like become works for role dependencies in meta/main.yml, so I can remove it from playbooks/katello_devel.yml and add it back as needed per role dependency in roles/katello_devel/meta/main.yml

ekohl

Actually, the commit message no longer matches the content of the commit.

wbclark · 2024-02-22T16:44:08Z

Actually, the commit message no longer matches the content of the commit.

I haven't gotten back implementing the role variable yet either. I was out sick, but will get to that today

Forcing become: true on the entire role was breaking the behavior of the customize_home role dependency

This was only working when run under the vagrant user

evgeni

We should drop the scl roles, they would need become true also, but are unused.

roles/katello_devel/meta/main.yml

These were no longer used as we don't need EL7 devel envs. Of these roles, the postgresql_scl and nodejs_scl roles are not used elsewhere in the project, and are dropped entirely. The ruby_scl role remains as it is still used in hammer and dynflow devel envs.

wbclark · 2024-02-26T17:09:06Z

We should drop the scl roles, they would need become true also, but are unused.

I pushed a change that removes the SCL roles from katello_devel

Two of these were now also unused in other roles and playbooks, so I removed those roles entirely.

wbclark · 2024-02-26T17:18:57Z

We should drop the scl roles, they would need become true also, but are unused.

Eh, so I checked /roles and /playbooks but these were in fact still used in the katello_devel pipeline.

I've updated that to use the centos8-stream box as a base now, and removed the SCL roles there as well.

wbclark · 2024-02-26T17:23:01Z

roles/katello_devel/meta/main.yml

    foreman_installer_scenario: katello-devel
    foreman_installer_additional_packages:
      - foreman-installer-katello
    foreman_installer_disable_system_checks: true
    foreman_installer_options_internal_use_only:
-      - "{{ '--katello-devel-scl-ruby=' +  ruby_scl_version if ansible_distribution_major_version == '7' else '' }}"


(this was already removed in puppet-katello_devel)

wbclark · 2024-02-27T14:49:44Z

Also, if you prefer the removal of unused SCL roles and change to centos8-stream in katello-katello devel pipelines in separate PRs, let me know and I'll make the change

evgeni

There are separate commits, so this looks good to me!

wbclark · 2024-02-29T14:39:15Z

@ekohl would you be willing to remove the out of date "changes requested" flag please?

it's fine

wbclark · 2024-02-29T15:40:52Z

What sorcery is that! Didn't realize it was possible.

Also, I cannot merge in this repository -- would you please, @evgeni ?

evgeni · 2024-02-29T15:41:48Z

I think this sorcery is limited to people with commit rights ;-)

(done)

wbclark · 2024-02-29T15:42:27Z

TYVM!

wbclark force-pushed the ansible_user_home branch from 3884f7c to 46b916a Compare February 9, 2024 02:29

wbclark commented Feb 9, 2024

View reviewed changes

roles/customize_home/tasks/main.yml Outdated Show resolved Hide resolved

wbclark force-pushed the ansible_user_home branch from 46b916a to afec60f Compare February 9, 2024 04:09

wbclark changed the title ~~Use ansible_env.HOME in customize_home role~~ Use ansible_user in customize_home role Feb 9, 2024

evgeni reviewed Feb 13, 2024

View reviewed changes

wbclark force-pushed the ansible_user_home branch from afec60f to 0c865ba Compare February 13, 2024 16:11

ekohl approved these changes Feb 16, 2024

View reviewed changes

ekohl previously requested changes Feb 16, 2024

View reviewed changes

pr-processor bot added the Waiting on contributor label Feb 16, 2024

wbclark added 2 commits February 23, 2024 13:58

Use become: true only where needed in katello_devel role

6b95ffb

Forcing become: true on the entire role was breaking the behavior of the customize_home role dependency

Use ansible_user_home in customize_home role

9822b1f

This was only working when run under the vagrant user

wbclark force-pushed the ansible_user_home branch from 0c865ba to 9822b1f Compare February 23, 2024 19:01

wbclark changed the title ~~Use ansible_user in customize_home role~~ Use ansible_user_dir in customize_home role Feb 23, 2024

evgeni reviewed Feb 24, 2024

View reviewed changes

roles/katello_devel/meta/main.yml Show resolved Hide resolved

wbclark force-pushed the ansible_user_home branch from a889dfc to 5a753c6 Compare February 26, 2024 17:07

Update katello_devel pipeline to use centos8-stream

9529ac8

wbclark commented Feb 26, 2024

View reviewed changes

wbclark requested review from ekohl and evgeni February 28, 2024 21:52

evgeni approved these changes Feb 28, 2024

View reviewed changes

evgeni merged commit f42a9b6 into theforeman:master Feb 29, 2024
8 checks passed

wbclark deleted the ansible_user_home branch February 29, 2024 15:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use ansible_user_dir in customize_home role #1760

Use ansible_user_dir in customize_home role #1760

wbclark commented Feb 8, 2024

evgeni Feb 13, 2024

wbclark Feb 13, 2024

wbclark Feb 14, 2024

wbclark Feb 14, 2024

evgeni Feb 15, 2024

evgeni Feb 16, 2024

wbclark Feb 22, 2024

wbclark Feb 22, 2024

wbclark Feb 22, 2024 •

edited

Loading

ekohl left a comment

wbclark commented Feb 22, 2024

evgeni left a comment

wbclark commented Feb 26, 2024

wbclark commented Feb 26, 2024

wbclark Feb 26, 2024

wbclark commented Feb 27, 2024

evgeni left a comment

wbclark commented Feb 29, 2024

wbclark commented Feb 29, 2024

evgeni commented Feb 29, 2024

wbclark commented Feb 29, 2024

	path: "/home/{{ ansible_user }}/foreman/.env"
	path: "{{ ansible_user_dir }}/foreman/.env"

Use ansible_user_dir in customize_home role #1760

Use ansible_user_dir in customize_home role #1760

Conversation

wbclark commented Feb 8, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wbclark Feb 22, 2024 • edited Loading

Choose a reason for hiding this comment

ekohl left a comment

Choose a reason for hiding this comment

wbclark commented Feb 22, 2024

evgeni left a comment

Choose a reason for hiding this comment

wbclark commented Feb 26, 2024

wbclark commented Feb 26, 2024

Choose a reason for hiding this comment

wbclark commented Feb 27, 2024

evgeni left a comment

Choose a reason for hiding this comment

wbclark commented Feb 29, 2024

wbclark commented Feb 29, 2024

evgeni commented Feb 29, 2024

wbclark commented Feb 29, 2024

wbclark Feb 22, 2024 •

edited

Loading