-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix installation of non-develop katello-devel box #1708
base: master
Are you sure you want to change the base?
Conversation
dc5ef42
to
72edf9e
Compare
72edf9e
to
3b1a619
Compare
3b1a619
to
b375a39
Compare
b375a39
to
6f0f931
Compare
6f0f931
to
7fd8004
Compare
7fd8004
to
543e287
Compare
roles/katello_devel/meta/main.yml
Outdated
- "--katello-devel-extra-plugins theforeman/foreman_rh_cloud" | ||
- "--katello-devel-extra-plugins theforeman/foreman_virt_who_configure" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really always need this? This breaks the installation of a non-nightly version, because it always takes the latest version.
If we want to always install this (without making it optional), this would also need a possibility to configure the specific SCM-version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably also a question for @chris1984 , because you added this in #1783
I would rather have it in centos9-katello-devel
sample definition (see diff), so one can opt-out 😁 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with that, we just added it since we were doing a lot of work with virt-who at the time and also now doing work with rh_cloud. Feel free to move it out @m-bucher where it can be opt-out if needed.
requires theforeman/puppet-katello_devel@e276ccb Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
543e287
to
44e16f2
Compare
The example probably does not work, since the mentioned fix to puppet-katello_devel is probably not available in the yum-repositories.
Requires theforeman/puppet-katello_devel@e276ccb