Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly query non-SCL'ed hammer version on EL8 #1207

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Sep 11, 2020

Refs: #1206

@ehelms ehelms merged commit 082b7e9 into theforeman:master Sep 11, 2020
@ekohl
Copy link
Member

ekohl commented Sep 11, 2020

Can't we add a Provides: hammer-cli = %{version} to our spec and query on that? The benefit is that you can also simply run yum install hammer-cli. Similarly, we have foreman-plugin-$plugin provides. That reminds me to check back if Puppet supports this nowadays.

@evgeni
Copy link
Member Author

evgeni commented Sep 11, 2020

@ekohl we can (and should), but you can't rpm -q on a provides, so in this particular case we'd still be out of luck how to find the version of the installed hammer.

@ekohl
Copy link
Member

ekohl commented Sep 11, 2020

Ah, that's probably also why in the past Puppet didn't support it properly - it used rpm to detect the current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants