Halt upgrades if evr is not owned by foreman #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehelms
reviewed
Nov 16, 2024
| def run | ||
| # No check is needed if the evr extension does not exist | ||
| evr_exists = find_evr_exists | ||
| return if !evr_exists |
There was a problem hiding this comment.
I think you could just turn this into more of a evr_exists? method, so that you can reduce these two lines to:
return unless evr_exists?
ehelms
reviewed
Nov 16, 2024
| error_msg = 'The evr extension is not owned by the foreman DB owner. Please run the following command to fix it: ' \ | ||
| "UPDATE pg_extension SET extowner = (SELECT oid FROM pg_authid WHERE rolname='foreman') WHERE extname='evr';" | ||
| foreman_owns_evr = find_foreman_owns_evr | ||
| fail!(error_msg) if !foreman_owns_evr |
There was a problem hiding this comment.
Same idea here, switch to foreman_owns_evr? method name and then do:
fail!(error_msg) unless foreman_own_evr?
ehelms
reviewed
Nov 16, 2024
| fail!('Could not determine if the evr extension is owned by the foreman DB owner') | ||
| end | ||
|
|
||
| def self.query_for_evr_existence |
There was a problem hiding this comment.
This does not need to be a class method
ehelms
reviewed
Nov 16, 2024
| SQL | ||
| end | ||
|
|
||
| def self.query_to_find_evr_owner |
There was a problem hiding this comment.
This does not need to be a class method
ehelms
reviewed
Nov 16, 2024
| end | ||
|
|
||
| def run | ||
| # No check is needed if the evr extension does not exist |
There was a problem hiding this comment.
You can drop this, the code reads well enough to tell me what's happening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Halts upgrades if the
evrextension in Katello external DBs are not owned byforeman. Skips the checks if theevrextension does not exist.Related installer PR: theforeman/foreman-installer#984