Allow skipping of update phases when they were already executed #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
commented
Sep 26, 2024
evgeni
force-pushed
the
skip-update-phases
branch
from
cc82318
to
330b2fb
Compare
evgeni
commented
Sep 26, 2024
| def with_non_empty_scenario(phase) | ||
| next_scenario = scenario(phase) | ||
| next_scenario = find_scenario(phase) |
There was a problem hiding this comment.
this was unused, so nobody noticed
evgeni
commented
Sep 26, 2024
Comment on lines
-98
to
+112
| rollback_needed = scenario(:pre_migrations).steps.any? { |s| s.executed? && s.success? } | ||
| rollback_needed = find_scenario(:pre_migrations).steps.any? { |s| s.executed? && s.success? } |
There was a problem hiding this comment.
I am amazed this was not noticed
evgeni
force-pushed
the
skip-update-phases
branch
from
4454faa
to
93ae9d8
Compare
evgeni
commented
Sep 26, 2024
Comment on lines
+39
to
+43
| if skip?(phase) | ||
| skip_phase(phase) | ||
| else | ||
| run_phase(phase) | ||
| end |
There was a problem hiding this comment.
Due to 3a2fa00 there is currently no way to re-run a skipped phase tho :(
|
I tested with the packit build on el8, which helps solve the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: 5c59f9c