-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #37166 - Add procedure to remove corrupted host statuses #798
Open
sbernhard
wants to merge
1
commit into
theforeman:master
Choose a base branch
from
ATIX-AG:add_fix_host_status
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
43 changes: 43 additions & 0 deletions
43
definitions/procedures/foreman/remove_corrupted_host_statuses.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
module Procedures::Foreman | ||
class RemoveCorruptedHostStatuses < ForemanMaintain::Procedure | ||
metadata do | ||
for_feature :foreman_database | ||
description 'Remove corrupted host statuses' | ||
end | ||
|
||
def run | ||
corrupted = collect_host_status_with_type_nil | ||
if corrupted.empty? | ||
skip("No corrupted host status. Everything fine. Exit.") | ||
end | ||
|
||
print("Detected corrupted host statuses:\n") | ||
corrupted.each do |s| | ||
print("Host #{s['host_name']} has corrupted host_status with id #{s['host_status_id']}\n") | ||
end | ||
|
||
answer = ask_decision("Do you want to remove the statuses", actions_msg: 'y(yes), q(quit)') | ||
abort! unless answer == :yes | ||
|
||
with_spinner('Removing corrupted host statuses') do | ||
delete_host_status_with_type_nil | ||
end | ||
end | ||
|
||
private | ||
|
||
def collect_host_status_with_type_nil | ||
feature(:foreman_database).query( | ||
"SELECT hosts.name AS host_name, host_status.id AS host_status_id | ||
FROM hosts, host_status | ||
WHERE host_status.type IS NULL AND hosts.id = host_status.host_id" | ||
) | ||
end | ||
|
||
def delete_host_status_with_type_nil | ||
feature(:foreman_database).psql( | ||
"DELETE FROM host_status WHERE type IS NULL" | ||
) | ||
end | ||
end | ||
end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not included in any scenarios - where are you wanting it to run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Actually I was unsure if we want to have this to run on every upgrade or backup or other places.
The procedures can be called as a single routine and I think it make sense to have a collection of these "maintenance" routines which can solve issues. What are your thougths?