Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37096 - Add rubocop to github actions #794

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

dosas
Copy link
Contributor

@dosas dosas commented Jan 25, 2024

No description provided.

@dosas
Copy link
Contributor Author

dosas commented Jan 25, 2024

I do not understand why the rubocop target did not run foir this PR?
Does it require configuration in the settings or does the file have to be on main?

Copy link
Contributor

@sbernhard sbernhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehelms
Copy link
Member

ehelms commented Jan 25, 2024

The current workflow runs bundle exec rake which captures rubocop and tests based on the default. If we want to break out the rubocop to it's own entry, I think we should update the workflow so that it only runs the unit tests alongside the change.

https://github.com/theforeman/foreman_maintain/blob/master/Rakefile#L23

@ehelms
Copy link
Member

ehelms commented Jan 25, 2024

I do not understand why the rubocop target did not run foir this PR?
Does it require configuration in the settings or does the file have to be on main?

The tests do not automatically run unless you are a public member of theforeman organization. I approved and ran it but see my comment.

@ehelms ehelms merged commit c02f351 into theforeman:master Feb 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants